Restart sync/set max time #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamdiel
reviewed
Aug 27, 2024
rainwavebot.py
Outdated
| traceback.print_exc() | ||
| #print(f"checkSyncThreadIsAlive error: {returnedException}") #NOTE Not required here, but I want to keep it noted as an example. | ||
| #traceback.print_exc() #NOTE Not required here, but I want to keep it noted as an example. | ||
| threadIsAlive = False |
There was a problem hiding this comment.
I'm not sure I'm understanding the intent of lines 55/56. I think they will always get run?
There was a problem hiding this comment.
I guess what are we doing with threadIsAlive at all? Not sure we need to set a var at all?
adamdiel
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Start sync removed from
playcommand, moved topostCurrentlyListeningvia new functioncheckSyncThreadIsAlive()/ This checks the thread every refresh in case it ended for some reason.generateProgressBar()now checks to make sure the song has not played longer than the maximum value of.lengthand replaces it with the max value if violated. Also reduces.seconds.variable time conversion by one instance.