Skip to content

Commit

Permalink
CLI - Fix stale helptext instructing users to use spacetime identity (
Browse files Browse the repository at this point in the history
#1954)

Co-authored-by: Zeke Foppa <bfops@users.noreply.github.com>
  • Loading branch information
bfops and bfops authored Nov 9, 2024
1 parent 7f9903d commit a432c62
Showing 1 changed file with 1 addition and 5 deletions.
6 changes: 1 addition & 5 deletions crates/cli/src/util.rs
Original file line number Diff line number Diff line change
Expand Up @@ -259,11 +259,7 @@ pub fn unauth_error_context<T>(res: anyhow::Result<T>, identity: &str, server: &
res.with_context(|| {
format!(
"Identity {identity} is not valid for server {server}.
Has the server rotated its keys?
Remove the outdated identity with:
\tspacetime identity remove -i {identity}
Generate a new identity with:
\tspacetime identity new --no-email --server {server} --default"
Please log back in with `spacetime logout` and then `spacetime login`."
)
})
}
Expand Down

2 comments on commit a432c62

@github-actions
Copy link

@github-actions github-actions bot commented on a432c62 Nov 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Criterion benchmark results

Criterion benchmark report

YOU SHOULD PROBABLY IGNORE THESE RESULTS.

Criterion is a wall time based benchmarking system that is extremely noisy when run on CI. We collect these results for longitudinal analysis, but they are not reliable for comparing individual PRs.

Go look at the callgrind report instead.

empty

db on disk new latency old latency new throughput old throughput
sqlite 💿 412.2±2.17ns 417.3±2.10ns - -
sqlite 🧠 404.0±1.61ns 406.9±1.90ns - -
stdb_raw 💿 779.0±0.89ns 773.1±1.31ns - -
stdb_raw 🧠 778.9±1.13ns 775.1±14.64ns - -

insert_1

db on disk schema indices preload new latency old latency new throughput old throughput

insert_bulk

db on disk schema indices preload count new latency old latency new throughput old throughput
sqlite 💿 u32_u64_str btree_each_column 2048 256 585.8±0.61µs 601.5±48.38µs 1706 tx/sec 1662 tx/sec
sqlite 💿 u32_u64_str unique_0 2048 256 152.0±0.63µs 149.9±0.25µs 6.4 Ktx/sec 6.5 Ktx/sec
sqlite 💿 u32_u64_u64 btree_each_column 2048 256 471.0±0.44µs 473.7±0.54µs 2.1 Ktx/sec 2.1 Ktx/sec
sqlite 💿 u32_u64_u64 unique_0 2048 256 137.8±0.61µs 145.0±7.71µs 7.1 Ktx/sec 6.7 Ktx/sec
sqlite 🧠 u32_u64_str btree_each_column 2048 256 446.5±0.37µs 450.9±0.46µs 2.2 Ktx/sec 2.2 Ktx/sec
sqlite 🧠 u32_u64_str unique_0 2048 256 121.3±1.06µs 123.3±0.67µs 8.0 Ktx/sec 7.9 Ktx/sec
sqlite 🧠 u32_u64_u64 btree_each_column 2048 256 368.8±0.77µs 374.8±0.41µs 2.6 Ktx/sec 2.6 Ktx/sec
sqlite 🧠 u32_u64_u64 unique_0 2048 256 105.8±0.61µs 111.9±0.48µs 9.2 Ktx/sec 8.7 Ktx/sec
stdb_raw 💿 u32_u64_str btree_each_column 2048 256 587.6±21.64µs 611.7±19.51µs 1701 tx/sec 1634 tx/sec
stdb_raw 💿 u32_u64_str unique_0 2048 256 467.3±45.28µs 496.8±28.18µs 2.1 Ktx/sec 2012 tx/sec
stdb_raw 💿 u32_u64_u64 btree_each_column 2048 256 378.9±5.66µs 379.7±10.22µs 2.6 Ktx/sec 2.6 Ktx/sec
stdb_raw 💿 u32_u64_u64 unique_0 2048 256 299.3±7.61µs 338.9±18.55µs 3.3 Ktx/sec 2.9 Ktx/sec
stdb_raw 🧠 u32_u64_str btree_each_column 2048 256 294.9±0.15µs 298.0±0.19µs 3.3 Ktx/sec 3.3 Ktx/sec
stdb_raw 🧠 u32_u64_str unique_0 2048 256 229.6±0.43µs 229.3±0.32µs 4.3 Ktx/sec 4.3 Ktx/sec
stdb_raw 🧠 u32_u64_u64 btree_each_column 2048 256 232.6±0.27µs 238.4±0.16µs 4.2 Ktx/sec 4.1 Ktx/sec
stdb_raw 🧠 u32_u64_u64 unique_0 2048 256 210.0±0.13µs 209.9±0.19µs 4.7 Ktx/sec 4.7 Ktx/sec

iterate

db on disk schema indices new latency old latency new throughput old throughput
sqlite 💿 u32_u64_str unique_0 23.5±0.13µs 23.8±0.18µs 41.5 Ktx/sec 41.0 Ktx/sec
sqlite 💿 u32_u64_u64 unique_0 21.5±0.24µs 22.0±0.17µs 45.3 Ktx/sec 44.4 Ktx/sec
sqlite 🧠 u32_u64_str unique_0 20.8±0.18µs 21.1±0.07µs 46.8 Ktx/sec 46.2 Ktx/sec
sqlite 🧠 u32_u64_u64 unique_0 19.1±0.39µs 19.5±0.09µs 51.1 Ktx/sec 50.0 Ktx/sec
stdb_raw 💿 u32_u64_str unique_0 4.0±0.00µs 4.0±0.00µs 246.4 Ktx/sec 246.6 Ktx/sec
stdb_raw 💿 u32_u64_u64 unique_0 3.9±0.00µs 3.9±0.00µs 253.0 Ktx/sec 253.0 Ktx/sec
stdb_raw 🧠 u32_u64_str unique_0 3.9±0.00µs 4.0±0.00µs 247.3 Ktx/sec 247.0 Ktx/sec
stdb_raw 🧠 u32_u64_u64 unique_0 3.9±0.00µs 3.9±0.00µs 253.2 Ktx/sec 253.2 Ktx/sec

find_unique

db on disk key type preload new latency old latency new throughput old throughput

filter

db on disk key type index strategy load count new latency old latency new throughput old throughput
sqlite 💿 string index 2048 256 69.5±0.34µs 70.7±0.25µs 14.1 Ktx/sec 13.8 Ktx/sec
sqlite 💿 u64 index 2048 256 66.0±0.38µs 66.7±0.26µs 14.8 Ktx/sec 14.6 Ktx/sec
sqlite 🧠 string index 2048 256 64.8±0.16µs 66.2±0.36µs 15.1 Ktx/sec 14.8 Ktx/sec
sqlite 🧠 u64 index 2048 256 60.1±0.16µs 60.6±0.19µs 16.2 Ktx/sec 16.1 Ktx/sec
stdb_raw 💿 string index 2048 256 5.0±0.00µs 5.0±0.00µs 195.6 Ktx/sec 195.6 Ktx/sec
stdb_raw 💿 u64 index 2048 256 4.9±0.00µs 4.9±0.00µs 198.7 Ktx/sec 198.7 Ktx/sec
stdb_raw 🧠 string index 2048 256 5.0±0.00µs 5.0±0.00µs 195.7 Ktx/sec 195.8 Ktx/sec
stdb_raw 🧠 u64 index 2048 256 4.9±0.00µs 4.9±0.00µs 198.6 Ktx/sec 198.6 Ktx/sec

serialize

schema format count new latency old latency new throughput old throughput
u32_u64_str bflatn_to_bsatn_fast_path 100 3.6±0.01µs 3.6±0.01µs 26.8 Mtx/sec 26.8 Mtx/sec
u32_u64_str bflatn_to_bsatn_slow_path 100 3.5±0.00µs 3.6±0.01µs 26.9 Mtx/sec 26.8 Mtx/sec
u32_u64_str bsatn 100 15.5±0.10ns 15.6±0.16ns 6.0 Gtx/sec 6.0 Gtx/sec
u32_u64_str bsatn 100 2.3±0.02µs 2.3±0.00µs 40.8 Mtx/sec 41.6 Mtx/sec
u32_u64_str json 100 4.9±0.05µs 5.0±0.11µs 19.4 Mtx/sec 19.1 Mtx/sec
u32_u64_str json 100 8.4±0.05µs 8.4±0.18µs 11.3 Mtx/sec 11.3 Mtx/sec
u32_u64_str product_value 100 1017.7±0.84ns 1018.5±0.52ns 93.7 Mtx/sec 93.6 Mtx/sec
u32_u64_u64 bflatn_to_bsatn_fast_path 100 950.0±14.12ns 976.9±3.65ns 100.4 Mtx/sec 97.6 Mtx/sec
u32_u64_u64 bflatn_to_bsatn_slow_path 100 2.8±0.05µs 2.8±0.00µs 34.3 Mtx/sec 34.4 Mtx/sec
u32_u64_u64 bsatn 100 14.8±0.00ns 14.8±0.01ns 6.3 Gtx/sec 6.3 Gtx/sec
u32_u64_u64 bsatn 100 1624.3±27.88ns 1587.4±26.85ns 58.7 Mtx/sec 60.1 Mtx/sec
u32_u64_u64 json 100 3.3±0.02µs 3.1±0.02µs 29.1 Mtx/sec 30.6 Mtx/sec
u32_u64_u64 json 100 6.2±0.05µs 5.8±0.19µs 15.4 Mtx/sec 16.5 Mtx/sec
u32_u64_u64 product_value 100 1015.7±0.52ns 1015.6±0.69ns 93.9 Mtx/sec 93.9 Mtx/sec
u64_u64_u32 bflatn_to_bsatn_fast_path 100 738.8±0.52ns 752.0±8.11ns 129.1 Mtx/sec 126.8 Mtx/sec
u64_u64_u32 bflatn_to_bsatn_slow_path 100 2.8±0.00µs 2.8±0.03µs 34.3 Mtx/sec 34.3 Mtx/sec
u64_u64_u32 bsatn 100 1636.2±24.71ns 1583.6±19.97ns 58.3 Mtx/sec 60.2 Mtx/sec
u64_u64_u32 bsatn 100 704.4±1.34ns 691.3±0.85ns 135.4 Mtx/sec 137.9 Mtx/sec
u64_u64_u32 json 100 3.4±0.03µs 3.4±0.05µs 28.1 Mtx/sec 28.1 Mtx/sec
u64_u64_u32 json 100 6.2±0.23µs 5.9±0.24µs 15.3 Mtx/sec 16.2 Mtx/sec
u64_u64_u32 product_value 100 1015.4±0.47ns 1014.6±0.63ns 93.9 Mtx/sec 94.0 Mtx/sec

stdb_module_large_arguments

arg size new latency old latency new throughput old throughput
64KiB 101.4±7.67µs 106.4±8.18µs - -

stdb_module_print_bulk

line count new latency old latency new throughput old throughput
1 52.2±5.07µs 52.4±5.85µs - -
100 596.5±9.84µs 600.0±20.36µs - -
1000 3.8±0.78ms 4.6±0.94ms - -

remaining

name new latency old latency new throughput old throughput
special/db_game/circles/load=10 35.7±2.65ms 51.9±6.55ms - -
special/db_game/circles/load=100 37.0±6.20ms 47.6±3.53ms - -
special/db_game/ia_loop/load=500 155.7±3.43ms 149.4±1.46ms - -
special/db_game/ia_loop/load=5000 5.7±0.03s 5.4±0.03s - -
sqlite/💿/update_bulk/u32_u64_str/unique_0/load=2048/count=256 54.8±0.07µs 55.4±0.20µs 17.8 Ktx/sec 17.6 Ktx/sec
sqlite/💿/update_bulk/u32_u64_u64/unique_0/load=2048/count=256 46.7±0.24µs 47.2±0.22µs 20.9 Ktx/sec 20.7 Ktx/sec
sqlite/🧠/update_bulk/u32_u64_str/unique_0/load=2048/count=256 39.3±0.22µs 40.4±0.22µs 24.9 Ktx/sec 24.2 Ktx/sec
sqlite/🧠/update_bulk/u32_u64_u64/unique_0/load=2048/count=256 35.2±0.14µs 36.6±0.42µs 27.8 Ktx/sec 26.7 Ktx/sec
stdb_module/💿/update_bulk/u32_u64_str/unique_0/load=2048/count=256 1275.2±11.74µs 1284.4±9.37µs 784 tx/sec 778 tx/sec
stdb_module/💿/update_bulk/u32_u64_u64/unique_0/load=2048/count=256 990.9±9.88µs 974.3±16.09µs 1009 tx/sec 1026 tx/sec
stdb_raw/💿/update_bulk/u32_u64_str/unique_0/load=2048/count=256 629.0±26.03µs 625.2±21.78µs 1589 tx/sec 1599 tx/sec
stdb_raw/💿/update_bulk/u32_u64_u64/unique_0/load=2048/count=256 445.2±4.53µs 487.1±7.66µs 2.2 Ktx/sec 2.0 Ktx/sec
stdb_raw/🧠/update_bulk/u32_u64_str/unique_0/load=2048/count=256 368.0±1.39µs 367.1±0.48µs 2.7 Ktx/sec 2.7 Ktx/sec
stdb_raw/🧠/update_bulk/u32_u64_u64/unique_0/load=2048/count=256 327.3±0.85µs 325.4±0.35µs 3.0 Ktx/sec 3.0 Ktx/sec

@github-actions
Copy link

@github-actions github-actions bot commented on a432c62 Nov 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Callgrind benchmark results

Callgrind Benchmark Report

These benchmarks were run using callgrind,
an instruction-level profiler. They allow comparisons between sqlite (sqlite), SpacetimeDB running through a module (stdb_module), and the underlying SpacetimeDB data storage engine (stdb_raw). Callgrind emulates a CPU to collect the below estimates.

Measurement changes larger than five percent are in bold.

In-memory benchmarks

callgrind: empty transaction

db total reads + writes old total reads + writes Δrw estimated cycles old estimated cycles Δcycles
stdb_raw 6399 6399 0.00% 6523 6523 0.00%
sqlite 5579 5579 0.00% 6019 6019 0.00%

callgrind: filter

db schema indices count preload _column data_type total reads + writes old total reads + writes Δrw estimated cycles old estimated cycles Δcycles
stdb_raw u32_u64_str no_index 64 128 1 u64 76593 76593 0.00% 77013 76993 0.03%
stdb_raw u32_u64_str no_index 64 128 2 string 119091 120180 -0.91% 119687 120876 -0.98%
stdb_raw u32_u64_str btree_each_column 64 128 2 string 25085 25083 0.01% 25617 25635 -0.07%
stdb_raw u32_u64_str btree_each_column 64 128 1 u64 24051 24051 0.00% 24447 24411 0.15%
sqlite u32_u64_str no_index 64 128 2 string 144695 144695 0.00% 146257 146261 -0.00%
sqlite u32_u64_str no_index 64 128 1 u64 124044 124044 0.00% 125334 125334 0.00%
sqlite u32_u64_str btree_each_column 64 128 1 u64 131361 131361 0.00% 132799 132807 -0.01%
sqlite u32_u64_str btree_each_column 64 128 2 string 134494 134494 0.00% 136104 136096 0.01%

callgrind: insert bulk

db schema indices count preload total reads + writes old total reads + writes Δrw estimated cycles old estimated cycles Δcycles
stdb_raw u32_u64_str unique_0 64 128 877138 877752 -0.07% 931798 901436 3.37%
stdb_raw u32_u64_str btree_each_column 64 128 1024221 1026497 -0.22% 1065829 1098517 -2.98%
sqlite u32_u64_str unique_0 64 128 398320 398320 0.00% 415186 415186 0.00%
sqlite u32_u64_str btree_each_column 64 128 983637 983637 0.00% 1020529 1020517 0.00%

callgrind: iterate

db schema indices count total reads + writes old total reads + writes Δrw estimated cycles old estimated cycles Δcycles
stdb_raw u32_u64_str unique_0 1024 153726 153726 0.00% 153866 153866 0.00%
stdb_raw u32_u64_str unique_0 64 16751 16751 0.00% 16875 16875 0.00%
sqlite u32_u64_str unique_0 1024 1067255 1067255 0.00% 1070663 1070663 0.00%
sqlite u32_u64_str unique_0 64 76207 76225 -0.02% 77445 77463 -0.02%

callgrind: serialize_product_value

count format total reads + writes old total reads + writes Δrw estimated cycles old estimated cycles Δcycles
64 json 47528 47528 0.00% 50282 50282 0.00%
64 bsatn 25509 25509 0.00% 27821 27821 0.00%
16 bsatn 8200 8200 0.00% 9628 9628 0.00%
16 json 12188 12188 0.00% 14194 14194 0.00%

callgrind: update bulk

db schema indices count preload total reads + writes old total reads + writes Δrw estimated cycles old estimated cycles Δcycles
stdb_raw u32_u64_str unique_0 1024 1024 20490259 20491189 -0.00% 21136189 21135011 0.01%
stdb_raw u32_u64_str unique_0 64 128 1284538 1284612 -0.01% 1325984 1326866 -0.07%
sqlite u32_u64_str unique_0 1024 1024 1802182 1802182 0.00% 1811362 1811362 0.00%
sqlite u32_u64_str unique_0 64 128 128528 128528 0.00% 131492 131492 0.00%
On-disk benchmarks

callgrind: empty transaction

db total reads + writes old total reads + writes Δrw estimated cycles old estimated cycles Δcycles
stdb_raw 6404 6404 0.00% 6544 6544 0.00%
sqlite 5621 5621 0.00% 6121 6121 0.00%

callgrind: filter

db schema indices count preload _column data_type total reads + writes old total reads + writes Δrw estimated cycles old estimated cycles Δcycles
stdb_raw u32_u64_str no_index 64 128 1 u64 76598 76598 0.00% 76978 76978 0.00%
stdb_raw u32_u64_str no_index 64 128 2 string 119096 119096 0.00% 119884 119840 0.04%
stdb_raw u32_u64_str btree_each_column 64 128 2 string 25088 25088 0.00% 25572 25556 0.06%
stdb_raw u32_u64_str btree_each_column 64 128 1 u64 24056 24056 0.00% 24404 24400 0.02%
sqlite u32_u64_str no_index 64 128 1 u64 125965 125965 0.00% 127543 127543 0.00%
sqlite u32_u64_str no_index 64 128 2 string 146616 146616 0.00% 148450 148454 -0.00%
sqlite u32_u64_str btree_each_column 64 128 2 string 136616 136616 0.00% 138724 138724 0.00%
sqlite u32_u64_str btree_each_column 64 128 1 u64 133457 133457 0.00% 135341 135341 0.00%

callgrind: insert bulk

db schema indices count preload total reads + writes old total reads + writes Δrw estimated cycles old estimated cycles Δcycles
stdb_raw u32_u64_str unique_0 64 128 826099 826364 -0.03% 879673 880130 -0.05%
stdb_raw u32_u64_str btree_each_column 64 128 976494 977421 -0.09% 1047160 1048145 -0.09%
sqlite u32_u64_str unique_0 64 128 415857 415857 0.00% 431867 431871 -0.00%
sqlite u32_u64_str btree_each_column 64 128 1021898 1021898 0.00% 1057622 1057622 0.00%

callgrind: iterate

db schema indices count total reads + writes old total reads + writes Δrw estimated cycles old estimated cycles Δcycles
stdb_raw u32_u64_str unique_0 1024 153731 153731 0.00% 153855 153855 0.00%
stdb_raw u32_u64_str unique_0 64 16756 16756 0.00% 16880 16876 0.02%
sqlite u32_u64_str unique_0 1024 1070323 1070323 0.00% 1074097 1074097 0.00%
sqlite u32_u64_str unique_0 64 77973 77973 0.00% 79303 79303 0.00%

callgrind: serialize_product_value

count format total reads + writes old total reads + writes Δrw estimated cycles old estimated cycles Δcycles
64 json 47528 47528 0.00% 50282 50282 0.00%
64 bsatn 25509 25509 0.00% 27821 27821 0.00%
16 bsatn 8200 8200 0.00% 9628 9628 0.00%
16 json 12188 12188 0.00% 14194 14194 0.00%

callgrind: update bulk

db schema indices count preload total reads + writes old total reads + writes Δrw estimated cycles old estimated cycles Δcycles
stdb_raw u32_u64_str unique_0 1024 1024 19001267 19000207 0.01% 19640773 19634465 0.03%
stdb_raw u32_u64_str unique_0 64 128 1238283 1237175 0.09% 1309651 1309763 -0.01%
sqlite u32_u64_str unique_0 1024 1024 1809743 1809743 0.00% 1818455 1818455 0.00%
sqlite u32_u64_str unique_0 64 128 132654 132654 0.00% 135834 135834 0.00%

Please sign in to comment.