Fix benches for ia_loop, circles (#1922)

crates/bench/benches/special.rs

@@ -9,7 +9,7 @@ use spacetimedb_bench::{
 use spacetimedb_lib::{bsatn::ToBsatn as _, sats, ProductValue};
 use spacetimedb_schema::schema::TableSchema;
 use spacetimedb_testing::modules::start_runtime;
-use std::time::{Duration, Instant};
+use std::sync::OnceLock;
 use std::{hint::black_box, sync::Arc};
 
 #[global_allocator]
@@ -62,53 +62,48 @@ fn custom_db_benchmarks(c: &mut Criterion) {
     let module = runtime.block_on(async { BENCHMARKS_MODULE.load_module(config, None).await });
     let mut group = c.benchmark_group("special");
     // This bench take long, so adjust for it
-    group.measurement_time(Duration::from_secs(60 * 2));
     group.sample_size(10);
 
+    let init_db: OnceLock<()> = OnceLock::new();
     for n in [10, 100] {
         let args = sats::product![n];
         group.bench_function(&format!("db_game/circles/load={n}"), |b| {
-            b.iter_custom(|iters| {
+            // Initialize outside the benchmark so the db is seed once, to avoid to enlarge the db
+            init_db.get_or_init(|| {
                 runtime.block_on(async {
                     module
-                        .call_reducer_binary("init_game_circles", args.clone())
+                        .call_reducer_binary("init_game_circles", sats::product![100])
                         .await
                         .unwrap()
                 });
+            });
 
-                let start = Instant::now();
-
-                for _ in 0..iters {
-                    black_box(
-                        runtime.block_on(async {
-                            module.call_reducer_binary("run_game_circles", args.clone()).await.ok()
-                        }),
-                    );
-                }
-
-                start.elapsed()
+            b.iter(|| {
+                black_box(
+                    runtime.block_on(async { module.call_reducer_binary("run_game_circles", args.clone()).await.ok() }),
+                );
             })
         });
     }
 
-    for n in [10, 100] {
+    let init_db: OnceLock<()> = OnceLock::new();
+    for n in [500, 5_000] {
         let args = sats::product![n];
         group.bench_function(&format!("db_game/ia_loop/load={n}"), |b| {
-            b.iter_custom(|_iters| {
+            // Initialize outside the benchmark so the db is seed once, to avoid `unique` constraints violations
+            init_db.get_or_init(|| {
                 runtime.block_on(async {
                     module
-                        .call_reducer_binary("init_game_ia_loop", args.clone())
+                        .call_reducer_binary("init_game_ia_loop", sats::product![5_000])
                         .await
-                        .unwrap()
-                });
-
-                let start = Instant::now();
+                        .unwrap();
+                })
+            });
 
+            b.iter(|| {
                 black_box(
                     runtime.block_on(async { module.call_reducer_binary("run_game_ia_loop", args.clone()).await.ok() }),
                 );
-
-                start.elapsed()
             })
         });
     }

crates/testing/tests/standalone_integration_test.rs

@@ -314,7 +314,7 @@ fn test_calling_bench_db_ia_loop() {
                 ("update_position_all", 20_000, "UPDATE POSITION ALL: 20000, processed: 20000"),
                 ("update_position_with_velocity", 10_000, "UPDATE POSITION BY VELOCITY: 10000, processed: 10000"),
                 ("insert_world", 5_000, "INSERT WORLD PLAYERS: 5000"),
-                ("game_loop_enemy_ia", 5_000, "ENEMY IA LOOP PLAYERS: 5000, processed: 2500"),
+                ("game_loop_enemy_ia", 5_000, "ENEMY IA LOOP PLAYERS: 5000, processed: 5000"),
             ];
 
             _run_bench_db(module, &benches).await

modules/benchmarks/src/ia_loop.rs

@@ -347,7 +347,7 @@ fn move_agent(
         entity_id,
         location_x: mobile_entity.location_x + 1,
         location_y: mobile_entity.location_y + 1,
-        timestamp: moment_milliseconds(),
+        timestamp: agent.next_action_timestamp,
     };
 
     ctx.db.game_enemy_ai_agent_state().entity_id().update(agent.clone());
@@ -394,10 +394,6 @@ pub fn game_loop_enemy_ia(ctx: &ReducerContext, players: u64) {
     let current_time_ms = moment_milliseconds();
 
     for mut agent in ctx.db.game_enemy_ai_agent_state().iter() {
-        if agent.next_action_timestamp > current_time_ms {
-            continue;
-        }
-
         let agent_targetable = ctx
             .db
             .game_targetable_state()