Special reducers don't preserve user-defined names #1891
Assignees
Labels
Comments
RReverser
added a commit
that referenced
this issue
Nov 28, 2024
Migrated C# ModuleDef to V9 as well as adds tests to ensure that identical modules indeed produce identical schemas. The two remaining discrepancies between Rust and C# are: - #1891 - Row-level security not having a designed API & implementation for C#. - Fixes #1948. - Fixes #1589. - Supersedes #1619.
RReverser
added a commit
that referenced
this issue
Nov 28, 2024
Migrated C# ModuleDef to V9 as well as adds tests to ensure that identical modules indeed produce identical schemas. The two remaining discrepancies between Rust and C# are: - #1891 - Row-level security not having a designed API & implementation for C#. - Fixes #1948. - Fixes #1589. - Supersedes #1619.
RReverser
added a commit
that referenced
this issue
Dec 9, 2024
Migrated C# ModuleDef to V9 as well as adds tests to ensure that identical modules indeed produce identical schemas. The two remaining discrepancies between Rust and C# are: - #1891 - Row-level security not having a designed API & implementation for C#. - Fixes #1948. - Fixes #1589. - Supersedes #1619.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As per recent API revamp proposal, special reducers attached to
init/client_connected/client_disconnectedevents should preserve user-provided names and use the V9 moduledef out-of-band signal to indicate the lifecycle event it's attached to.I'm working on the C# counterpart of this (V8 -> V9 migration), but I noticed that Rust implementation of the bindings macro, which already supports V9 moduledef, doesn't preserve the reducer names either.
cc @gefjon
The text was updated successfully, but these errors were encountered: