Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add row count metric for each table #505

Closed
joshua-spacetime opened this issue Oct 31, 2023 · 2 comments · Fixed by #525
Closed

Add row count metric for each table #505

joshua-spacetime opened this issue Oct 31, 2023 · 2 comments · Fixed by #525
Assignees

Comments

@joshua-spacetime
Copy link
Collaborator

joshua-spacetime commented Oct 31, 2023

From @kurtismullins:

There are currently metrics around the time it takes to do various operations to tables. To shine a little context on these operations, lets expose a metric which simply states how many rows a given table has.

If this already exists, feel free to just let me know and close this issue. I couldn't find it but may have missed it. An example metric which would be more useful if we knew the row count is: spacetime_rdb_iter_time_count.

@joshua-spacetime
Copy link
Collaborator Author

Now that we have metrics for inserted and deleted rows

spacetime_num_rows_inserted_cumulative
spacetime_num_rows_deleted_cumulative

This metric can be derived as the difference between the two.

@joshua-spacetime
Copy link
Collaborator Author

joshua-spacetime commented Nov 2, 2023

Actually it would be better for this to be its own metric (gauge) because inserts - deletes will not be accurate unless starting from 0.

@joshua-spacetime joshua-spacetime self-assigned this Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant