Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change units of histogram metrics from nanoseconds to seconds #520

Closed
joshua-spacetime opened this issue Nov 3, 2023 · 0 comments · Fixed by #522
Closed

Change units of histogram metrics from nanoseconds to seconds #520

joshua-spacetime opened this issue Nov 3, 2023 · 0 comments · Fixed by #522
Assignees
@joshua-spacetime

Comments

@joshua-spacetime
Copy link
Collaborator

The default Prometheus histogram buckets assume seconds represented as an f64.
@joshua-spacetime joshua-spacetime self-assigned this Nov 3, 2023
joshua-spacetime added a commit that referenced this issue Nov 3, 2023
@joshua-spacetime
refactor(520): Change histogram units from nanos to fractional secs
4170afa 
The default prometheus histogram buckets are meant to be interpreted as f64 seconds.
Because previously we were using nanosecond units,
all observations were being placed in the last (+inf) bucket.
This change was made to avoid modifying the default bucket specification.

Fixes #520.
@joshua-spacetime joshua-spacetime mentioned this issue Nov 3, 2023
Merged
4 tasks
joshua-spacetime added a commit that referenced this issue Nov 3, 2023
@joshua-spacetime
refactor(520): Change histogram units from nanos to fractional secs
5e6240c 
Fixes #520.

The default prometheus histogram buckets are meant to be interpreted as f64 seconds.
Because previously we were using nanosecond units,
all observations were being placed in the last (+inf) bucket.
This change was made to avoid modifying the default bucket specification.
joshua-spacetime added a commit that referenced this issue Nov 4, 2023
@joshua-spacetime
refactor(520): Change histogram units from nanos to fractional secs
9bd9e42 
Fixes #520.

The default prometheus histogram buckets are meant to be interpreted as f64 seconds.
Because previously we were using nanosecond units,
all observations were being placed in the last (+inf) bucket.
This change was made to avoid modifying the default bucket specification.
joshua-spacetime added a commit that referenced this issue Nov 4, 2023
@joshua-spacetime
refactor(520): Change histogram units from nanos to fractional secs (#…
82fe0f7 
…522)

Fixes #520.

The default prometheus histogram buckets are meant to be interpreted as f64 seconds.
Because previously we were using nanosecond units,
all observations were being placed in the last (+inf) bucket.
This change was made to avoid modifying the default bucket specification.
kulakowski pushed a commit that referenced this issue Nov 7, 2023
@joshua-spacetime @kulakowski
refactor(520): Change histogram units from nanos to fractional secs (#…
c42d482 
…522)

Fixes #520.

The default prometheus histogram buckets are meant to be interpreted as f64 seconds.
Because previously we were using nanosecond units,
all observations were being placed in the last (+inf) bucket.
This change was made to avoid modifying the default bucket specification.
kulakowski pushed a commit that referenced this issue Nov 7, 2023
@joshua-spacetime @kulakowski
refactor(520): Change histogram units from nanos to fractional secs (#…
5b33b7d 
…522)

Fixes #520.

The default prometheus histogram buckets are meant to be interpreted as f64 seconds.
Because previously we were using nanosecond units,
all observations were being placed in the last (+inf) bucket.
This change was made to avoid modifying the default bucket specification.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joshua-spacetime joshua-spacetime

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(520): Change histogram units from nanos to fractional secs clockworklabs/SpacetimeDB
1 participant
@joshua-spacetime