-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MultiMap
: don't sort values; use .push(..)
and .swap_remove(..)
instead
#1029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Centril
changed the title
MultiMap: don't sort values; use
Mar 27, 2024
.push(..)
and .swap_remove(..)
insteadMultiMap
: don't sort values; use .push(..)
and .swap_remove(..)
instead
Bot test resultsConclusion: Possible improvements in Commits testedbefore:
after:
|
Bot test resultsConclusion: Possible small savings. Commits testedbefore:
after:
|
Centril
force-pushed
the
centril/multi-map-unsorted-vals
branch
from
April 5, 2024 17:36
ea08cdb
to
865e744
Compare
joshua-spacetime
approved these changes
Apr 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
This avoids sorting values
V
s when inserting into the multi-map.It should have no impact where there are few values that share the same key, but it might otherwise.
API and ABI breaking changes
None
Expected complexity level and risk
3 - previously this failed in CI, and if it doesn't, we should be sure that it doesn't break some untested semantics before merging.