Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI - Set default server to testnet #1078

Merged
merged 13 commits into from
Apr 25, 2024

Conversation

dylanh724
Copy link
Contributor

@dylanh724 dylanh724 commented Apr 11, 2024

Description of Changes

testnet is quite stable now and makes onboarding (both the UX and docs) a significantly more-streamlined experience

image

API and ABI breaking changes

(This is technically a breaking change? I'm not quite sure what label to apply)

Expected complexity level and risk

*How complicated do you think these changes are? Grade on a scale from 1 to 5,
2

⚠️ There may be some tooling that assumes local if they never explicitly set it to testnet.

Testing

Describe any testing you've done, and any testing you'd like your reviewers to do,
so that you're confident that all the changes work as expected!

  • Try it in a new user env

- from "local"
- Suggested by Tyler
@dylanh724 dylanh724 requested a review from cloutiertyler April 11, 2024 07:50
@bfops bfops added the CLI only This change only affects the CLI behavior label Apr 15, 2024
@dylanh724 dylanh724 requested review from bfops and jdetter April 17, 2024 06:23
@dylanh724
Copy link
Contributor Author

Specific poke to @jdetter - heard you're working on CLI stuff now!👋

crates/cli/src/config.rs Outdated Show resolved Hide resolved
@jdetter
Copy link
Collaborator

jdetter commented Apr 19, 2024

We originally had the CLI pointing to testnet by default, I don't remember the exact reason why we changed it back to local. Changing it back to testnet has some implications but we could possibly get this into the next release. I'll talk to Tyler about it today.

@jdetter jdetter added the release-any To be landed in any release window label Apr 19, 2024
@cloutiertyler
Copy link
Contributor

We originally had the CLI pointing to testnet by default, I don't remember the exact reason why we changed it back to local. Changing it back to testnet has some implications but we could possibly get this into the next release. I'll talk to Tyler about it today.

The reason was that testnet was not stable and we were afraid that people would be trying to do the tutorial while Testnet was down. Now that it has been more stable, I think this change makes sense.

@dylanh724 dylanh724 requested a review from jdetter April 23, 2024 02:43
Copy link
Collaborator

@jdetter jdetter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bfops bfops enabled auto-merge April 23, 2024 18:29
@jdetter jdetter disabled auto-merge April 23, 2024 18:31
Copy link
Collaborator

@jdetter jdetter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have to double check that the smoketests are working properly after this change

Zeke Foppa added 3 commits April 24, 2024 12:36
@bfops bfops changed the base branch from master to bfops/tests-use-explicit-server April 24, 2024 19:37
@bfops bfops force-pushed the dylan/refactor/set-default-server-to-testnet branch from 05bcf6f to 124ca39 Compare April 24, 2024 20:05
@bfops bfops changed the base branch from bfops/tests-use-explicit-server to master April 24, 2024 20:05
@bfops bfops changed the base branch from master to bfops/tests-use-explicit-server April 24, 2024 20:10
Zeke Foppa added 3 commits April 24, 2024 13:10
…4ce5ed3e6434111e2c25' into bfops/tests-use-explicit-server
… branch 'origin/bfops/tests-use-explicit-server' into dylan/refactor/set-default-server-to-testnet
@bfops bfops changed the base branch from bfops/tests-use-explicit-server to bfops/default-server-inline April 24, 2024 20:30
Zeke Foppa added 2 commits April 24, 2024 13:30
… branch 'origin/bfops/default-server-inline' into dylan/refactor/set-default-server-to-testnet
@bfops bfops changed the title Dylan/refactor/set-default-server-to-testnet CLI - Set default server to testnet Apr 24, 2024
@jdetter
Copy link
Collaborator

jdetter commented Apr 25, 2024

We'll have to rework this PR after #1151 lands

Base automatically changed from bfops/default-server-inline to master April 25, 2024 04:45
… branch 'origin/master' into dylan/refactor/set-default-server-to-testnet
Copy link
Collaborator

@jdetter jdetter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@bfops bfops added this pull request to the merge queue Apr 25, 2024
Merged via the queue into master with commit 2085691 Apr 25, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLI only This change only affects the CLI behavior release-any To be landed in any release window
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants