-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLI - Set default server to testnet
#1078
Conversation
- from "local" - Suggested by Tyler
Specific poke to @jdetter - heard you're working on CLI stuff now!👋 |
We originally had the CLI pointing to testnet by default, I don't remember the exact reason why we changed it back to local. Changing it back to testnet has some implications but we could possibly get this into the next release. I'll talk to Tyler about it today. |
The reason was that testnet was not stable and we were afraid that people would be trying to do the tutorial while Testnet was down. Now that it has been more stable, I think this change makes sense. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have to double check that the smoketests are working properly after this change
… branch 'origin/bfops/tests-use-explicit-server' into dylan/refactor/set-default-server-to-testnet
05bcf6f
to
124ca39
Compare
…4ce5ed3e6434111e2c25' into bfops/tests-use-explicit-server
… branch 'origin/bfops/tests-use-explicit-server' into dylan/refactor/set-default-server-to-testnet
… branch 'origin/bfops/default-server-inline' into dylan/refactor/set-default-server-to-testnet
testnet
We'll have to rework this PR after #1151 lands |
… branch 'origin/master' into dylan/refactor/set-default-server-to-testnet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Description of Changes
testnet
is quite stable now and makes onboarding (both the UX and docs) a significantly more-streamlined experienceAPI and ABI breaking changes
(This is technically a breaking change? I'm not quite sure what label to apply)
Expected complexity level and risk
*How complicated do you think these changes are? Grade on a scale from 1 to 5,
2
Testing
Describe any testing you've done, and any testing you'd like your reviewers to do,
so that you're confident that all the changes work as expected!