perf: optimize Table::clone_structure by avoiding clones
#1090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Centril
force-pushed
the
centril/arc-table-schema
branch
from
2df0cb5 to
bcbbb55
Compare
- Arcing `TableSchema`, and this has benefits elsewhere too. - Arc<[_]>ing the visitor program instructions. The data behind the Arcs very rarely change, which is the perfect case for an Arc.
Centril
force-pushed
the
centril/arc-table-schema
branch
from
bcbbb55 to
6d87288
Compare
kim
reviewed
Apr 16, 2024
| @@ -622,8 +623,7 @@ impl spacetimedb_commitlog::payload::txdata::Visitor for ReplayVisitor<'_> { | |||
| ) -> std::result::Result<Self::Row, Self::Error> { | |||
| let schema = self | |||
| .committed_state | |||
| .schema_for_table(&ExecutionContext::default(), table_id)? | |||
| .into_owned(); | |||
| .schema_for_table(&ExecutionContext::default(), table_id)?; | |||
There was a problem hiding this comment.
This should be a noticeable improvement 👍
cloutiertyler
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Fixes #1082
Fixes #1084
Make Table::clone_structure cheaper by:
TableSchema, and this has benefits elsewhere too.The data behind the Arcs very rarely change,
which is the perfect case for an Arc.
API and ABI breaking changes
None
Expected complexity level and risk
2
Testing
No semantic changes nor anything that is very interesting, so existing tests should suffice.