Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dylan/doc: Link directly to cargo install on missing #1102

Conversation

dylanh724
Copy link
Contributor

Description of Changes

  • doc: Link directly to cargo install on missing
    image

Why?

Most modern terminals parse links for you -- let's skip redundant research for the user.

@dylanh724 dylanh724 added the documentation Improvements or additions to documentation label Apr 17, 2024
@dylanh724 dylanh724 changed the title doc: Link directly to cargo install on missing Dylan/doc: Link directly to cargo install on missing Apr 17, 2024
@dylanh724
Copy link
Contributor Author

🤔Strange - how come I failed the contributor membership check?

image

@jdetter
Copy link
Collaborator

jdetter commented Apr 19, 2024

@coolreader18 It looks like you were the last one to modify the contributor check job, can you see what's going on here?

@dylanh724 dylanh724 force-pushed the dylan/doc/on-init-rust-module-no-cargo-link-website branch from 2c1bb75 to b99c3e9 Compare April 19, 2024 09:09
Copy link
Collaborator

@jdetter jdetter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I open the link on my windows machine I get the windows instructions and when I open the link on my macOS machine I get the macOS instructions, so this seems like a good change 👍

@bfops bfops self-assigned this Apr 24, 2024
@coolreader18 coolreader18 reopened this Apr 29, 2024
@coolreader18 coolreader18 merged commit d2b98e0 into clockworklabs:master Apr 29, 2024
15 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants