Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an inconsistency with spacetime server fingerprint #1131

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

jdetter
Copy link
Collaborator

@jdetter jdetter commented Apr 22, 2024

Description of Changes

Please describe your change, mention any related tickets, and so on here.

Previous command:

spacetime server fingerprint <server>

New command:

spacetime server fingerprint -s <server>

if no -s <server> is supplied, the default server will be fingerprinted.

API and ABI breaking changes

If this is an API or ABI breaking change, please apply the
corresponding GitHub label.

Technically yes, just a CLI change

Expected complexity level and risk

How complicated do you think these changes are? Grade on a scale from 1 to 5,
where 1 is a trivial change, and 5 is a deep-reaching and complex change.

This complexity rating applies not only to the complexity apparent in the diff,
but also to its interactions with existing and future code.

If you answered more than a 2, explain what is complex about the PR,
and what other components it interacts with in potentially concerning ways.

0

Testing

Describe any testing you've done, and any testing you'd like your reviewers to do,
so that you're confident that all the changes work as expected!

  • Write a test you've completed here.
  • Try spacetime server fingerprint and spacetime server fingerprint -s <server>

Copy link
Collaborator

@bfops bfops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️ Seems broadly correct

@bfops bfops added release-any To be landed in any release window CLI only This change only affects the CLI behavior labels Apr 22, 2024
@bfops bfops added this pull request to the merge queue Apr 22, 2024
Merged via the queue into master with commit 2712844 Apr 22, 2024
9 checks passed
bfops pushed a commit that referenced this pull request Apr 22, 2024
… <server> (#1131)

Co-authored-by: John Detter <no-reply@boppygames.gg>
@bfops bfops deleted the jdetter/fingerprint-takes-dash-s-for-server branch June 24, 2024 22:30
@bfops bfops added the api-break A PR that makes an API breaking change label Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api-break A PR that makes an API breaking change CLI only This change only affects the CLI behavior release-any To be landed in any release window
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants