fix(1173): Record wait time for all reducers #1174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+646
to
+651
| // Record the time spent waiting in the queue | ||
| let _guard = WORKER_METRICS | ||
| .reducer_wait_time | ||
| .with_label_values(&self.info.address, reducer) | ||
| .start_timer(); | ||
| self.inner.get_instance(self.info.address).await? |
There was a problem hiding this comment.
@coolreader18 do you agree that this is the correct place to be recording this metric? And that this works for all reducers?
There was a problem hiding this comment.
for all reducers and for other such calls. but yeah, this seems right.
coolreader18
approved these changes
Apr 29, 2024
Comment on lines
+646
to
+651
| // Record the time spent waiting in the queue | ||
| let _guard = WORKER_METRICS | ||
| .reducer_wait_time | ||
| .with_label_values(&self.info.address, reducer) | ||
| .start_timer(); | ||
| self.inner.get_instance(self.info.address).await? |
There was a problem hiding this comment.
for all reducers and for other such calls. but yeah, this seems right.
Fixes #1173. Previously we were only recording this metric for scheduled reducers. We were also recording it before we acquired access to the module instance. Now we record it for all reducers after we acquire access to the module instance. This patch also removes max wait time since the histogram should suffice.
joshua-spacetime
force-pushed
the
joshua/fix/1173/reducer-wait-time
branch
from
1847871 to
3df2a53
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1173.
Previously we were only recording this metric for scheduled reducers. We were also recording it before we acquired access to the module instance. Now we record it for all reducers after we acquire access to the module instance.
This patch also removes max wait time since the histogram should suffice.
Description of Changes
Please describe your change, mention any related tickets, and so on here.
API and ABI breaking changes
If this is an API or ABI breaking change, please apply the
corresponding GitHub label.
Expected complexity level and risk
How complicated do you think these changes are? Grade on a scale from 1 to 5,
where 1 is a trivial change, and 5 is a deep-reaching and complex change.
This complexity rating applies not only to the complexity apparent in the diff,
but also to its interactions with existing and future code.
If you answered more than a 2, explain what is complex about the PR,
and what other components it interacts with in potentially concerning ways.
Testing
Describe any testing you've done, and any testing you'd like your reviewers to do,
so that you're confident that all the changes work as expected!