Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NFC: few more C# shorthand syntax conversions #1176

Merged
merged 3 commits into from
Apr 30, 2024
Merged

Conversation

RReverser
Copy link
Member

Description of Changes

For some reason these automated refactoring conversions didn't get included in #1149.

API and ABI breaking changes

If this is an API or ABI breaking change, please apply the
corresponding GitHub label.

Expected complexity level and risk

How complicated do you think these changes are? Grade on a scale from 1 to 5,
where 1 is a trivial change, and 5 is a deep-reaching and complex change.

This complexity rating applies not only to the complexity apparent in the diff,
but also to its interactions with existing and future code.

If you answered more than a 2, explain what is complex about the PR,
and what other components it interacts with in potentially concerning ways.

Testing

Describe any testing you've done, and any testing you'd like your reviewers to do,
so that you're confident that all the changes work as expected!

  • Write a test you've completed here.
  • Write a test you want a reviewer to do here, so they can check it off when they're satisfied.

For some reason these automated refactoring conversions didn't get included in #1149.
@RReverser RReverser requested review from kazimuth and jdetter April 29, 2024 16:28
Copy link
Contributor

@kazimuth kazimuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending test fixes.

@bfops bfops added the release-any To be landed in any release window label Apr 29, 2024
@RReverser RReverser added this pull request to the merge queue Apr 30, 2024
Merged via the queue into master with commit 5cc05b1 Apr 30, 2024
7 checks passed
@RReverser RReverser deleted the csharp-more-shorthands branch April 30, 2024 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-any To be landed in any release window
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants