Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve bindings diagnostics and add ui tests #1216

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

coolreader18
Copy link
Collaborator

@coolreader18 coolreader18 commented May 13, 2024

Description of Changes

Wahoo Rust 1.78! Also, the symbol for a reducer in backtraces should now be something like spacetime_module::myreducer::invoke instead of <spacetime_module::myreducer as spacetimedb::rt::Reducer>::INVOKE

Expected complexity level and risk

1 - just diagnostic changes

@coolreader18 coolreader18 force-pushed the noa/improve-diagnostics branch from f0f37c6 to 56df74f Compare May 13, 2024 15:48
@bfops bfops added the release-any To be landed in any release window label May 13, 2024
@coolreader18 coolreader18 requested a review from Centril May 14, 2024 02:52
crates/bindings-macro/src/lib.rs Outdated Show resolved Hide resolved
crates/bindings-macro/src/lib.rs Outdated Show resolved Hide resolved
crates/bindings/tests/ui/reducers.stderr Outdated Show resolved Hide resolved
crates/bindings/src/rt.rs Outdated Show resolved Hide resolved
crates/bindings-macro/src/lib.rs Outdated Show resolved Hide resolved
crates/bindings-macro/src/lib.rs Outdated Show resolved Hide resolved
crates/bindings-macro/src/lib.rs Outdated Show resolved Hide resolved
@coolreader18 coolreader18 force-pushed the noa/improve-diagnostics branch 2 times, most recently from 0c1749b to 5e35bdb Compare October 15, 2024 18:57
@coolreader18 coolreader18 force-pushed the noa/improve-diagnostics branch from 5e35bdb to 392616c Compare October 15, 2024 19:19
@coolreader18 coolreader18 added this pull request to the merge queue Oct 16, 2024
Merged via the queue into master with commit a4d097c Oct 16, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-any To be landed in any release window
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants