Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regenerate C# types #1698

Closed
wants to merge 1 commit into from
Closed

Regenerate C# types #1698

wants to merge 1 commit into from

Conversation

RReverser
Copy link
Member

Description of Changes

I missed final regeneration in the ModuleDef generation PR (#1680).

API and ABI breaking changes

If this is an API or ABI breaking change, please apply the
corresponding GitHub label.

Expected complexity level and risk

How complicated do you think these changes are? Grade on a scale from 1 to 5,
where 1 is a trivial change, and 5 is a deep-reaching and complex change.

This complexity rating applies not only to the complexity apparent in the diff,
but also to its interactions with existing and future code.

If you answered more than a 2, explain what is complex about the PR,
and what other components it interacts with in potentially concerning ways.

Testing

Describe any testing you've done, and any testing you'd like your reviewers to do,
so that you're confident that all the changes work as expected!

  • Write a test you've completed here.
  • Write a test you want a reviewer to do here, so they can check it off when they're satisfied.

I missed final regeneration in the ModuleDef generation PR (#1680).
@RReverser RReverser requested a review from kazimuth September 11, 2024 16:30
Copy link
Contributor

@kazimuth kazimuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Do we wanna add a test to ensure this happens too?

@RReverser
Copy link
Member Author

Do we wanna add a test to ensure this happens too?

Yes, but maybe later 😅

@RReverser RReverser added this pull request to the merge queue Sep 11, 2024
@kazimuth kazimuth removed this pull request from the merge queue due to a manual request Sep 11, 2024
@RReverser
Copy link
Member Author

Covered by #1661.

@RReverser RReverser closed this Sep 11, 2024
@RReverser RReverser deleted the ingvar/regen-moduledef branch September 11, 2024 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants