RLS: Adding a new filter! macro #1849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mamcx
commented
Oct 14, 2024
mamcx
force-pushed
the
mamcx/filter-proc_macro
branch
from
7a34585 to
6e1b654
Compare
joshua-spacetime
changed the title
joshua-spacetime
approved these changes
Oct 16, 2024
mamcx
force-pushed
the
mamcx/filter-proc_macro
branch
2 times, most recently
from
21104a5 to
3d182f0
Compare
Co-authored-by: joshua-spacetime <josh@clockworklabs.io> Signed-off-by: Mario Montoya <mamcx@elmalabarista.com>
mamcx
force-pushed
the
mamcx/filter-proc_macro
branch
from
3d182f0 to
ab45658
Compare
lcodes
pushed a commit
that referenced
this pull request
Oct 25, 2024
Signed-off-by: Mario Montoya <mamcx@elmalabarista.com> Co-authored-by: joshua-spacetime <josh@clockworklabs.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Add a new
filter!proc-macrofor defining row-level security policies (rls) usingSQL.It is a continuation of #1746.
Closes #1602.
The new macro:
SQLquery at compile time using the subscription dialect. It is impossible to fully validate it until we publish the module and all the table definitions are already committed to the database.To avoid tracking a graph of dependencies, we remove and then add against all the
rlsand finally compile them to validate it.Expected complexity level and risk
1
Testing
Describe any testing you've done, and any testing you'd like your reviewers to do,
so that you're confident that all the changes work as expected!
auto_migration.py.cli