C# codegen making state relative to a DbConnection #1869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
jdetter
approved these changes
Oct 22, 2024
There was a problem hiding this comment.
Tested via clockworklabs/com.clockworklabs.spacetimedbsdk#176
Code looks good to me, thanks @lcodes!
RReverser
requested changes
Oct 22, 2024
jdetter
previously requested changes
Oct 22, 2024
There was a problem hiding this comment.
Ingvar left some requested changes here: clockworklabs/com.clockworklabs.spacetimedbsdk#168 (comment)
I'm temporarily removing my approval so that he has an opportunity to review here
lcodes
force-pushed
the
jeremie/cs-connection-state-fix
branch
from
70d929c to
7b083e2
Compare
|
@RReverser updated, should be good to go now |
RReverser
reviewed
Oct 25, 2024
RReverser
reviewed
Oct 25, 2024
RReverser
approved these changes
Oct 25, 2024
lcodes
force-pushed
the
jeremie/cs-connection-state-fix
branch
from
405cd7a to
65220bf
Compare
lcodes
force-pushed
the
jeremie/cs-connection-state-fix
branch
from
2caee9e to
2264653
Compare
jdetter
added a commit
to clockworklabs/com.clockworklabs.spacetimedbsdk
that referenced
this pull request
Oct 31, 2024
## Description of Changes *Describe what has been changed, any new features or bug fixes* - switched our "already connected" logic to using a reference to a `MonoBehaviour` instead of just a bool. `MonoBehaviour`s are typically destroyed when a scene reload happens and in this case we'll want to allow developers to spawn a new `SpacetimeDBNetworkManager` if the previous one has been destroyed. ## API This is *not* an API break. - [ ] This is an API breaking change to the SDK *If the API is breaking, please state below what will break* ## Requires SpacetimeDB PRs *List any PRs here that are required for this SDK change to work* - clockworklabs/SpacetimeDB#1869 ## Testsuite SpacetimeDB branch name: master ## Testing *Write instructions for a test that you performed for this PR* - [x] I have added in several new tests here, one of which is a reconnection test. Also, the reason why we couldn't have more than 1 test before this is that it was required for reconnections to be working in order to have multiple tests running in the testsuite. Now that we have fixed reconnections I have enabled all of the tests. Testsuite passes  --------- Co-authored-by: John Detter <no-reply@boppygames.gg> Co-authored-by: Mazdak Farrokhzad <twingoow@gmail.com> Co-authored-by: Jeremie Pelletier <jeremiep@gmail.com> Co-authored-by: Zeke Foppa <bfops@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Make the static fields indexing primary keys instance fields.
API and ABI breaking changes
Expected complexity level and risk
Testing
Codegen compiles. Same code as before but going through a
thispointer instead of astatic.Context from Boppy: The Unity testsuite exercises this feature in the testsuite: clockworklabs/com.clockworklabs.spacetimedbsdk#168