Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Physical query plan + executors #1881

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

joshua-spacetime
Copy link
Collaborator

@joshua-spacetime joshua-spacetime commented Oct 21, 2024

Closes #1766.

Introduces the physical query plan and a tuple-at-a-time iterator.

Missing:

  1. logical to physical lowering
  2. optimization
  3. physical plan to iterator

@joshua-spacetime joshua-spacetime force-pushed the joshua/feat/1766/physical-plan branch 2 times, most recently from 36585ca to 5cfb98e Compare October 22, 2024 20:05
crates/physical-plan/src/plan.rs Show resolved Hide resolved
crates/physical-plan/src/plan.rs Show resolved Hide resolved
crates/execution/src/iter.rs Show resolved Hide resolved
@joshua-spacetime joshua-spacetime force-pushed the joshua/feat/1766/physical-plan branch from 5cfb98e to 71b0c37 Compare October 22, 2024 20:07
Copy link
Contributor

@mamcx mamcx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Apart of the comments of @Centril I think is good, and we have meet twice about this.

@joshua-spacetime joshua-spacetime force-pushed the joshua/feat/1766/physical-plan branch from 71b0c37 to c6381d5 Compare October 24, 2024 17:12
@joshua-spacetime joshua-spacetime force-pushed the joshua/feat/1766/physical-plan branch from c6381d5 to 21e14fc Compare October 24, 2024 17:15
@joshua-spacetime joshua-spacetime changed the title feat(1766): Physical query plan Physical query plan + executors Oct 24, 2024
@joshua-spacetime joshua-spacetime added this pull request to the merge queue Oct 24, 2024
Merged via the queue into master with commit c840eda Oct 24, 2024
8 of 9 checks passed
@joshua-spacetime joshua-spacetime deleted the joshua/feat/1766/physical-plan branch October 24, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Query physical plan
3 participants