-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Physical query plan + executors #1881
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshua-spacetime
force-pushed
the
joshua/feat/1766/physical-plan
branch
2 times, most recently
from
October 22, 2024 20:05
36585ca
to
5cfb98e
Compare
Centril
reviewed
Oct 22, 2024
joshua-spacetime
force-pushed
the
joshua/feat/1766/physical-plan
branch
from
October 22, 2024 20:07
5cfb98e
to
71b0c37
Compare
Centril
reviewed
Oct 22, 2024
Centril
reviewed
Oct 22, 2024
Centril
reviewed
Oct 22, 2024
Centril
reviewed
Oct 22, 2024
mamcx
approved these changes
Oct 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Apart of the comments of @Centril I think is good, and we have meet twice about this.
joshua-spacetime
force-pushed
the
joshua/feat/1766/physical-plan
branch
from
October 24, 2024 17:12
71b0c37
to
c6381d5
Compare
joshua-spacetime
force-pushed
the
joshua/feat/1766/physical-plan
branch
from
October 24, 2024 17:15
c6381d5
to
21e14fc
Compare
joshua-spacetime
changed the title
feat(1766): Physical query plan
Physical query plan + executors
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1766.
Introduces the physical query plan and a tuple-at-a-time iterator.
Missing: