Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't autogen schedule fields #1894

Merged
merged 2 commits into from
Nov 22, 2024
Merged

Conversation

coolreader18
Copy link
Collaborator

Description of Changes

Resolves #1818

API and ABI breaking changes

module API–breaking, but a very very easy fix (copy-paste from the error message into your code and it's fixed). was deemed an okay breakage for rc1->rc2, if that's what ends up happening.

Expected complexity level and risk

1

@coolreader18 coolreader18 force-pushed the noa/no-autogen-sched-fields branch from 39e89e9 to 08b2fa0 Compare October 23, 2024 19:27
Copy link
Contributor

@gefjon gefjon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:excellent: Thanks for updating the test!

@bfops bfops removed the api-break label Nov 11, 2024
@coolreader18 coolreader18 added this pull request to the merge queue Nov 22, 2024
Merged via the queue into master with commit 94c66c9 Nov 22, 2024
7 of 8 checks passed
@bfops bfops added the api-break A PR that makes an API breaking change label Dec 2, 2024
cloutiertyler pushed a commit that referenced this pull request Dec 11, 2024
Co-authored-by: Phoebe Goldman <phoebe@goldman-tribe.org>
@coolreader18 coolreader18 deleted the noa/no-autogen-sched-fields branch February 11, 2025 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api-break A PR that makes an API breaking change release-rc1-nice-to-have
Projects
None yet
3 participants