Eliminate dependency on im; just mutate the client cache
#1897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This turns out to be effectively a prerequisite for client-side indices. Storing indexes in a type-erased way while making them `Clone` for storage in `im::HashMap` is likely possible, but it's at least very challenging and complex. Given that we no longer actually need the concurrent persistence offered by `im::HashMap`, it seems easier to just revert to using `std::collections::HashMap`.
1 task
gefjon
force-pushed
the
phoebe/sdk-ditch-im
branch
from
455f5be to
3e2c168
Compare
2 tasks
mamcx
reviewed
Oct 28, 2024
Centril
approved these changes
Oct 28, 2024
kazimuth
reviewed
Nov 15, 2024
coolreader18
approved these changes
Nov 27, 2024
|
Included in #1909 ; merging that and closing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
This turns out to be effectively a prerequisite for client-side indices. Storing indexes in a type-erased way
while making them
Clonefor storage inim::HashMapis likely possible, but it's at least very challenging and complex. Given that we no longer actually need the concurrent persistence offered byim::HashMap, it seems easier to just revert to usingstd::collections::HashMap.API and ABI breaking changes
Breaks SDK codegen. No user-facing breakage.
Expected complexity level and risk
2 - minor risk of deadlocks because the SDK's concurrency story is pretty complex, but well-tested so likely safe.
Testing