Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide "internal" datetime representation types #1921

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

RReverser
Copy link
Contributor

Description of Changes

These were accidentally exposed in top-level SpacetimeDB namespace. Move them to SpacetimeDB.Internal as they're not meant to be part of the public API.

API and ABI breaking changes

If this is an API or ABI breaking change, please apply the
corresponding GitHub label.

Expected complexity level and risk

How complicated do you think these changes are? Grade on a scale from 1 to 5,
where 1 is a trivial change, and 5 is a deep-reaching and complex change.

This complexity rating applies not only to the complexity apparent in the diff,
but also to its interactions with existing and future code.

If you answered more than a 2, explain what is complex about the PR,
and what other components it interacts with in potentially concerning ways.

Testing

Describe any testing you've done, and any testing you'd like your reviewers to do,
so that you're confident that all the changes work as expected!

  • Write a test you've completed here.
  • Write a test you want a reviewer to do here, so they can check it off when they're satisfied.

These were accidentally exposed in top-level SpacetimeDB namespace. Move them to SpacetimeDB.Internal as they're not meant to be part of the public API.
@RReverser RReverser requested a review from lcodes October 30, 2024 10:27
@RReverser RReverser added this pull request to the merge queue Oct 30, 2024
Merged via the queue into master with commit bc79f93 Oct 30, 2024
9 checks passed
@RReverser RReverser deleted the ingvar/hide-private-reprs branch October 30, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants