C# endianness fixes #1964
Merged
C# endianness fixes #1964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Okay this should be ready for merge |
RReverser
reviewed
Nov 11, 2024
crates/bindings-csharp/BSATN.Runtime.Tests/BSATN.Runtime.Tests.csproj
Outdated
Show resolved
Hide resolved
RReverser
reviewed
Nov 11, 2024
RReverser
reviewed
Nov 11, 2024
RReverser
reviewed
Nov 11, 2024
bfops
added
bugfix
bfops
added a commit
that referenced
this pull request
Nov 11, 2024
bfops
added a commit
to clockworklabs/com.clockworklabs.spacetimedbsdk
that referenced
this pull request
Nov 12, 2024
## Description of Changes We have included the packages corresponding to clockworklabs/SpacetimeDB#1964. ## API Fixes API breakage related to endianness. ## Requires SpacetimeDB PRs SpacetimeDB branch name: release/v1.0.0-rc1-hotfix2 ## Testsuite SpacetimeDB branch name: release/v1.0.0-rc1-hotfix2 ## Testing CI only --------- Co-authored-by: Mazdak Farrokhzad <twingoow@gmail.com> Co-authored-by: Zeke Foppa <bfops@users.noreply.github.com> Co-authored-by: Jeremie Pelletier <jeremiep@gmail.com> Co-authored-by: Ingvar Stepanyan <me@rreverser.com> Co-authored-by: SteveGibson <100594800+SteveBoytsun@users.noreply.github.com> Co-authored-by: Steve Boytsun <steve@clockwokrlabs.io> Co-authored-by: John Detter <4099508+jdetter@users.noreply.github.com> Co-authored-by: John Detter <no-reply@boppygames.gg> Co-authored-by: Tyler Cloutier <cloutiertyler@aol.com> Co-authored-by: Tyler Cloutier <cloutiertyler@users.noreply.github.com>
kazimuth
commented
Nov 12, 2024
kazimuth
commented
Nov 12, 2024
RReverser
approved these changes
Nov 13, 2024
There was a problem hiding this comment.
Approving with one final comment.
It probably needs its own anyway, since hex string parsing doesn't check for odd length.
I think this part got missed - passing an odd-length hex string like 012 would just ignore the 2 instead of throwing an error.
The rest looks good, thanks!
RReverser
reviewed
Nov 13, 2024
RReverser
reviewed
Nov 13, 2024
RReverser
reviewed
Nov 13, 2024
kazimuth
force-pushed
the
jgilles/csharp-endianness
branch
from
28c430a to
882bb54
Compare
RReverser
reviewed
Nov 13, 2024
|
I'm nervous about these internal test failures, I don't know what's causing them. |
These are a known issue that should hopefully be fixed by tomorrow. |
RReverser
reviewed
Nov 16, 2024
Centril
pushed a commit
to clockworklabs/com.clockworklabs.spacetimedbsdk
that referenced
this pull request
Nov 19, 2024
## Description of Changes Cherrypicking the changes from #190, which were merged directly to `master` (by me, without thinking it through). ## API Fixes API breakage related to endianness. ## Requires SpacetimeDB PRs clockworklabs/SpacetimeDB#1964 ## Testsuite SpacetimeDB branch name: master ## Testing CI only. These changes have already been released.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Similar fixes to the previous endianness fixes (#1926) for C#.
API and ABI breaking changes
Reverts a previous API break which (I believe) printed Identities and Addresses backwards in C#. Otherwise, only documents existing behavior & adds methods.
Expected complexity level and risk
1
Testing
I am not sure how to add unit tests to the C# bindings, @RReverser please advise. E: NVM, figured it out.