Speed up state_view::Iter by special casing committed-with-no-deletes
#2003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Centril
changed the title
state_view::Iter by special casing committed-with-no-deletes
Centril
force-pushed
the
centril/potentially-better-scan-stage-iter
branch
from
b008b75 to
e1dfd1c
Compare
joshua-spacetime
approved these changes
Nov 27, 2024
crates/core/src/db/datastore/locking_tx_datastore/state_view.rs
Outdated
Show resolved
Hide resolved
Centril
force-pushed
the
centril/potentially-better-scan-stage-iter
branch
from
e1dfd1c to
145c23f
Compare
Centril
force-pushed
the
centril/potentially-better-scan-stage-iter
branch
from
145c23f to
9217302
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Based on flamegraphs of
iter, this speeds it up by avoiding checking the delete tables for every committed row if there isn't a delete table. Meanwhile, here, we also only fetch the delete table once instead of for every committed row.Fixes #2012.
API and ABI breaking changes
None
Expected complexity level and risk
1, localized and already well tested change.