Remove MessageLogIter, use commit_log::Iter instead
#272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kim
commented
Sep 11, 2023
| for message in message_log.iter() { | ||
| for commit in commit_log::Iter::from(message_log.segments()) { | ||
| let commit = commit?; | ||
|
|
||
| segment_index += 1; |
There was a problem hiding this comment.
@aasoni Unsure why this is named segment_index when it counts commits (i.e. messages). If it is supposed to count commits, this could be further simplified via .enumerate().
There was a problem hiding this comment.
this may be a question for @cloutiertyler, I've only rearranged things in this function and added debug logging. Not sure why the original naming decision
There was a problem hiding this comment.
Okay... I guess I'll just leave it like that, then. Although it looks to me like last_commit_offset would suffice to compute the percentage.
cloutiertyler
pushed a commit
that referenced
this pull request
Oct 3, 2023
* core: Provide read access to commit/message log and odb This is a first approximation to provide data access for Kafka-style replication. It punts on notifications of segment rotation (which could also be solved via filesystem events). ObjectDB access is fairly crude, and will likely require it's own replication subsystem. * fixup! Merge remote-tracking branch 'origin/master' into kim/log-access * Add some tests Also make max segment size configurable, so tests don't have to write >= 1GiB worth of data. * Abide to the Rust naming conventions * Add test for commit iter * Remove `MessageLogIter`, use `commit_log::Iter` instead (#272)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #265