Prometheus stuff #301
Prometheus stuff #301
Conversation
| use spacetimedb_lib::{Address, Hash, Identity}; | ||
|
|
||
| #[macro_export] | ||
| macro_rules! metrics_group { |
There was a problem hiding this comment.
This is nice.
But also, possibly more generally useful than deep down the core crate? There is also a prometheus-macros crate on crates.io, maybe there is some overlap?
There was a problem hiding this comment.
Oh wow, there definitely is. That's funny lol, we had almost the same idea. I think in the future I'll look at expanding it to something more general (unsure about pulling it out into its own crate that I then publish or something, wrt licensing) but the one on crates.io doesn't let you make fields public (??) or else I might consider switching. I'm happy with the strong typing with this implementation, as well (not just strings everywhere).
There was a problem hiding this comment.
I meant maybe a workspace crate, or in lib, or somewhere near the top of the core crate module hierarchy. Just so me and others can find it easily for instrumenting other stuff.
There was a problem hiding this comment.
Ok, moved it to a submodule of spacetimedb_core::util
coolreader18
force-pushed
the
noa/prometheus-stuff
branch
3 times, most recently
from
101dd4e to
efe869f
Compare
|
I just wanted to say that I've been running with this changes on dev for a week or so and observing some of the metrics (like the queue length) and it works without any issues. Thanks for great work Noa! Also it would be great to merge it before 0.7.1, cause it's very useful for observing the load on the database, especially the module calls contention. |
coolreader18
force-pushed
the
noa/prometheus-stuff
branch
from
efe869f to
80f6f16
Compare
Description of Changes
Sorry, still in a bit of a funk, but figured I may as well just push what I have.
API and ABI
If the API is breaking, please state below what will break