V8: Enable as unstable, add syscalls, flesh out call_reducer, etc. #3276
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Centril
requested review from
bfops,
cloutiertyler and
jdetter
as code owners
Centril
changed the title
Centril
changed the title
|
Is this meant to be reviewed or just here for a demo? |
It's meant to be reviewed. |
Centril
force-pushed
the
centril/v8-syscalls
branch
from
5e12f1a to
e5f893d
Compare
bfops
reviewed
Sep 24, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 25, 2025
# Description of Changes Implements `Serialize` and `Deserialize` for tuples. Extracted from #3276. # API and ABI breaking changes None # Expected complexity level and risk 2 # Testing A test `roundtrip_tuples_in_different_data_formats` is added.
Centril
force-pushed
the
centril/v8-syscalls
branch
2 times, most recently
from
0454ff8 to
cfc090d
Compare
Centril
force-pushed
the
centril/v8-syscalls
branch
from
cfc090d to
e3b6a7b
Compare
Centril
force-pushed
the
centril/v8-syscalls
branch
from
8d9364c to
15c0871
Compare
bfops
reviewed
Oct 2, 2025
bfops
added
release-1.6
and removed
release-any
cloutiertyler
approved these changes
Oct 2, 2025
Centril
force-pushed
the
centril/v8-syscalls
branch
2 times, most recently
from
49251c9 to
5a9b6bc
Compare
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 3, 2025
# Description of Changes Extracted from #3276. # API and ABI breaking changes None # Expected complexity level and risk 1 # Testing Future work.
Centril
force-pushed
the
centril/v8-syscalls
branch
from
5a9b6bc to
2e1e644
Compare
auto-merge was automatically disabled
October 3, 2025 08:46
Merge commits are not allowed on this repository
Centril
force-pushed
the
centril/v8-syscalls
branch
3 times, most recently
from
0b7304b to
21baced
Compare
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 3, 2025
# Description of Changes Prefix of #3276 to bisect a problem in smoketests. # API and ABI breaking changes None # Expected complexity level and risk 1 # Testing Future work.
Centril
force-pushed
the
centril/v8-syscalls
branch
from
21baced to
af7140a
Compare
Centril
force-pushed
the
centril/v8-syscalls
branch
14 times, most recently
from
592752c to
ff1fe7b
Compare
cli/publish: expose --js-path to publish js module
Centril
force-pushed
the
centril/v8-syscalls
branch
from
ff1fe7b to
a9e52b4
Compare
Centril
changed the base branch from
centril/v8-syscalls-prefix-2
to
centril/v8-sysclls-prefix-4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
This PR:
unstablefeature flag on the host. To publish a JS module,--javascript --bin-path path/to/module.jsneeds to be used. This mechanism is provisional until we come up with something better.WasmInstanceEnvtoInstanceEnvand friends.create_instance,make_actor,call_reducerwith timeouts and long-running logs added as well.API and ABI breaking changes
None
Expected complexity level and risk
3? It's only available on unstable and mostly touches V8 stuff, but the PR is fairly big.
Testing
Follow up PRs will add unit tests for parts.
We'll also need to add integration tests for whole modules.