Skip to content

v8: use fast static strings for known strings #3351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 6, 2025
Merged

v8: use fast static strings for known strings #3351

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1cba64e
v8 -> 140.2, s/`HandleScope`/`PinScope`/g (#3349)
Centril Oct 6, 2025
9665f16
v8: use fast static strings for known strings
Centril Sep 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,12 @@ jobs:
$ErrorActionPreference = 'Stop'
$PSNativeCommandUseErrorActionPreference = $true

# Use a different linker. Otherwise, the build fails with some obscure linker error that
# seems to be a result of us producing a massive PDB file.
# I (@bfops) tried a variety of other link options besides switching linkers, but this
# seems to be the only thing that worked.
$env:RUSTFLAGS='-Clinker=lld-link'

cargo build -p spacetimedb-cli -p spacetimedb-standalone -p spacetimedb-update
Start-Process target/debug/spacetimedb-cli.exe -ArgumentList 'start --pg-port 5432'
cd modules
Expand Down Expand Up @@ -395,4 +401,3 @@ jobs:
echo "It looks like the CLI docs have changed:"
exit 1
fi

Loading
Loading