Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bench for sql scan #363

Closed
wants to merge 3 commits into from
Closed

Bench for sql scan #363

wants to merge 3 commits into from

Conversation

mamcx
Copy link
Contributor

@mamcx mamcx commented Oct 4, 2023

Description of Changes

Changes for hit the 500ms target loading the BitCraft game:

  • Bench for SQL queries: SELECT * FROM table / SELECT * FROM table WHERE pk = value
  • Instrument calls for tracy
  • Add tracy support in run_standalone_temp.sh

API and ABI

  • This is a breaking change to the module ABI
  • This is a breaking change to the module API
  • This is a breaking change to the ClientAPI
  • This is a breaking change to the SDK API

If the API is breaking, please state below what will break

@joshua-spacetime
Copy link
Collaborator

benchmarks please

let sql = format!("SELECT * FROM {table_name}");
let id = module.client.id.identity;
runtime.block_on(async move {
module.client.module.one_off_query(id, sql).await?;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this goes through wasm?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, I write this to avoid a todo! here, but I have not idea how round-trip with WASM.

crates/bench/src/spacetime_raw.rs Outdated Show resolved Hide resolved
crates/bench/src/spacetime_raw.rs Outdated Show resolved Hide resolved
crates/core/src/sql/execute.rs Outdated Show resolved Hide resolved
crates/core/src/vm.rs Outdated Show resolved Hide resolved
@mamcx mamcx closed this Oct 5, 2023
@mamcx mamcx deleted the mamcx/500ms branch October 5, 2023 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants