-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bench for SQL scan / where #370
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This PR broke the module benchmarks, FWIW. There is also a way to structure it that wouldn't have caused the issue. I would have appreciated if you had waited for my review. |
So, what should I do instead? |
Rather than adding trait methods to This means that each generic benchmark implementation is measuring a separate access path to the database. Times of the SQL api will be clearly separate from times of reducer calls. The specific thing that broke here is that a I'm working on a branch that reverts this, so that benchmarks will run on master. Then I'll start a new PR to add the spacetime-SQL benches, we can collab on that :) (We'll need to have no-ops for insertion benchmarks there, in some way. I guess we'll need to add an |
This partially reverts commit 05956d6.
Description of Changes
API and ABI
If the API is breaking, please state below what will break