SATS: Flatten AlgebraicType (Nix BuiltinType) #379
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Centril
force-pushed
the
centril/flatten-algebraic
branch
4 times, most recently
from
940e117 to
90ec74f
Compare
Centril
changed the title
Centril
changed the title
Centril
force-pushed
the
centril/flatten-algebraic
branch
7 times, most recently
from
8617bc0 to
b68b081
Compare
4 tasks
Centril
force-pushed
the
centril/flatten-algebraic
branch
7 times, most recently
from
9943679 to
17640ac
Compare
4 tasks
Centril
force-pushed
the
centril/flatten-algebraic
branch
2 times, most recently
from
5a6cc7c to
9399995
Compare
4 tasks
Centril
changed the title
Centril
force-pushed
the
centril/flatten-algebraic
branch
2 times, most recently
from
9a27676 to
d8faed1
Compare
Centril
force-pushed
the
centril/flatten-algebraic
branch
from
d8faed1 to
21c9ed5
Compare
Closed
1 task
Centril
force-pushed
the
centril/flatten-algebraic
branch
2 times, most recently
from
a6cc5f8 to
09bfc68
Compare
1 task
Centril
force-pushed
the
centril/flatten-algebraic
branch
3 times, most recently
from
e5b42ac to
8105110
Compare
mamcx
approved these changes
Oct 31, 2023
| @@ -342,7 +394,7 @@ mod tests { | |||
| fn algebraic_type() { | |||
| let algebraic_type = AlgebraicType::meta_type(); | |||
| assert_eq!( | |||
| "(sum: (variants: Array<(name: (some: String | none: ()), algebraic_type: &0)>) | product: (elements: Array<(name: (some: String | none: ()), algebraic_type: &0)>) | builtin: (bool: () | i8: () | u8: () | i16: () | u16: () | i32: () | u32: () | i64: () | u64: () | i128: () | u128: () | f32: () | f64: () | string: () | array: &0 | map: (key_ty: &0, ty: &0)) | ref: U32)", | |||
| "(ref: U32 | sum: (variants: Array<(name: (some: String | none: ()), algebraic_type: &0)>) | product: (elements: Array<(name: (some: String | none: ()), algebraic_type: &0)>) | array: &0 | map: (key_ty: &0, ty: &0) | bool: () | i8: () | u8: () | i16: () | u16: () | i32: () | u32: () | i64: () | u64: () | i128: () | u128: () | f32: () | f64: () | string: ())", | |||
There was a problem hiding this comment.
Question: Because the type is structural is not the order significant?
Centril
force-pushed
the
centril/flatten-algebraic
branch
from
8105110 to
2869549
Compare
|
Closing in favor of: #1559 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Flattens
BuiltinTypeintoAlgebraicType.See note below on BSATN ABI breakage.
API and ABI
If the API is breaking, please state below what will break
BSATN does not change for
AlgebraicValuebut it does forAlgebraicTypeas this includes tags for each variant so the indirection ofBuiltinTypewas present in the codec but is no longer.