Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Now that our ABI checks can handle binaries produced by wasm-opt, we can use it (if installed) to optimise produced Wasm binaries.
For now it's added as an optional step until we figure out a decent deployment strategy to automatically get it for the user. (There are some wrappers on crates.io, but they tend to lag behind modern versions and take a while to compile, whereas Binaryen provides official prebuilt binaries on Github.)
This gives an easy 8-10% performance boost in iteration benchmarks, much more for an empty table but that's less interesting.
API and ABI
If the API is breaking, please state below what will break
Expected complexity level and risk
*How complicated do you think these changes are? Grade on a scale from 1 to 5,
1
This complexity rating applies not only to the complexity apparent in the diff,
but also to its interactions with existing and future code.
If you answered more than a 2, explain what is complex about the PR,
and what other components it interacts with in potentially concerning ways.