Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix authorization check for CrudCode #431

Merged
merged 2 commits into from
Oct 16, 2023
Merged

Fix authorization check for CrudCode #431

merged 2 commits into from
Oct 16, 2023

Conversation

kim
Copy link
Contributor

@kim kim commented Oct 16, 2023

Description of Changes

Make all mutating SQL operations require the caller to be the database owner.

API and ABI

  • This is a breaking change to the module ABI
  • This is a breaking change to the module API
  • This is a breaking change to the ClientAPI
  • This is a breaking change to the SDK API

Expected complexity level and risk

How complicated do you think these changes are? Grade on a scale from 1 to 5,
where 1 is a trivial change, and 5 is a deep-reaching and complex change.

1

kim added 2 commits October 16, 2023 09:23
Make all mutating SQL operations require the caller to be the database
owner.
@kim kim enabled auto-merge (squash) October 16, 2023 18:28
Copy link
Contributor

@cloutiertyler cloutiertyler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kim kim merged commit 41f9fac into master Oct 16, 2023
5 checks passed
@kim kim deleted the kim/fix-auth branch October 16, 2023 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants