Reuse Wasm-side buffer while reading iterators #435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will be mainly useful on large iterations that span over our 64KiB chunks.
|
Woops, gonna fix in a sec. |
|
Conceptually makes sense. This doesn't change the buffer sharing protocol for all the iteration stuff, correct, so it's not an ABI break? The wasm side was and is responsible. |
Correct, this is purely Wasm-side optimisation with no ABI change. |
RReverser
commented
Oct 16, 2023
| @@ -263,7 +263,11 @@ fn buffer_table_iter( | |||
| let mut iter = sys::iter(table_id, filter.as_deref())?; | |||
|
|
|||
| // First item is an encoded schema. | |||
| let schema_raw = iter.next().expect("Missing schema").expect("Failed to get schema"); | |||
| let schema_raw = iter | |||
There was a problem hiding this comment.
FWIW this will go away if/when #420 is merged, so will also become simpler.
kulakowski
approved these changes
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Reuse buffer when reading new chunks from the iterator, instead of freeing and allocating a new one each time.
This will be mainly useful on large iterations that span over our 64KiB chunks.
API and ABI
If the API is breaking, please state below what will break
Expected complexity level and risk
How complicated do you think these changes are? Grade on a scale from 1 to 5,
where 1 is a trivial change, and 5 is a deep-reaching and complex change.
This complexity rating applies not only to the complexity apparent in the diff,
but also to its interactions with existing and future code.
If you answered more than a 2, explain what is complex about the PR,
and what other components it interacts with in potentially concerning ways.