core: Track the number of bytes read when iterating over the WAL #496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
Setting to draft until #495 lands. I intend to use this for error context as well. |
kim
force-pushed
the
kim/log-iter-count-bytes
branch
2 times, most recently
from
8e4c0b1 to
5f9c052
Compare
kulakowski
approved these changes
Nov 6, 2023
kim
force-pushed
the
kim/log-iter-count-bytes
branch
from
5f9c052 to
7c5d13c
Compare
Mainly for providing additional error context when commit decoding fails.
kim
force-pushed
the
kim/log-iter-count-bytes
branch
from
7c5d13c to
1080027
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Prerequisite for being able to truncate log segments without seeking, e.g. while replaying up until a corrupted record.Above did not turn out to be feasible, but I think the additional error context is worthwhile.
API and ABI
If the API is breaking, please state below what will break
Expected complexity level and risk
1