Added multi column index usage to the rust-wasm-test module #500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Did this tickle the very brittle standalone integration test? It has a comment about needing to run things in order, and the failing assertion is that the number of lines in some log output is off. |
|
Yes I think the test is failing because creating the index writes to the module log. |
kulakowski
approved these changes
Nov 1, 2023
The number of lines in the output changes as there is 1 additional line corresponding to the new table.
kulakowski
pushed a commit
that referenced
this pull request
Nov 7, 2023
Added multi column index usage to the rust-wasm-test module This also updates integration test. The number of lines in the output changes as there is 1 additional line corresponding to the new table.
kulakowski
pushed a commit
that referenced
this pull request
Nov 7, 2023
Added multi column index usage to the rust-wasm-test module This also updates integration test. The number of lines in the output changes as there is 1 additional line corresponding to the new table.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Just adds usage of the multi column index macro feature
API and ABI
If the API is breaking, please state below what will break
Expected complexity level and risk
How complicated do you think these changes are? Grade on a scale from 1 to 5,
where 1 is a trivial change, and 5 is a deep-reaching and complex change.
This complexity rating applies not only to the complexity apparent in the diff,
but also to its interactions with existing and future code.
If you answered more than a 2, explain what is complex about the PR,
and what other components it interacts with in potentially concerning ways.
`