Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(472): Add metric for index seeks and keys scanned #501

Merged
merged 3 commits into from
Oct 30, 2023

Conversation

joshua-spacetime
Copy link
Collaborator

Closes #472.

Description of Changes

API and ABI

  • This is a breaking change to the module ABI
  • This is a breaking change to the module API
  • This is a breaking change to the ClientAPI
  • This is a breaking change to the SDK API

If the API is breaking, please state below what will break

Expected complexity level and risk

How complicated do you think these changes are? Grade on a scale from 1 to 5,
where 1 is a trivial change, and 5 is a deep-reaching and complex change.

This complexity rating applies not only to the complexity apparent in the diff,
but also to its interactions with existing and future code.

If you answered more than a 2, explain what is complex about the PR,
and what other components it interacts with in potentially concerning ways.

Copy link
Contributor

@cloutiertyler cloutiertyler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with comment.

@joshua-spacetime joshua-spacetime enabled auto-merge (squash) October 30, 2023 23:22
@joshua-spacetime joshua-spacetime merged commit 7623404 into master Oct 30, 2023
5 checks passed
@joshua-spacetime joshua-spacetime deleted the joshua/perf/472/keys-scanned-metric branch October 31, 2023 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Record metric for the number of index keys scanned
2 participants