Format binary data as hex in sql/satn #521
Conversation
crates/core/src/control_db/tests.rs
Outdated
| let dbs = cdb.get_databases()?; | ||
|
|
||
| assert_eq!(dbs.len(), 1); | ||
| assert_eq!(dbs[0].id, id); |
There was a problem hiding this comment.
What are you testing here? Shouldn't you be checking identity rather than id?
There was a problem hiding this comment.
I agree with Josh, not sure what is going on here.
| ]); | ||
| let data = r#" | ||
| { | ||
| "foo": 42, | ||
| "bar": "404040FFFF0A48656C6C6F", | ||
| "baz": ["heyyyyyy", "hooo"], | ||
| "quux": { "Hash": "54a3e6d2b0959deaacf102292b1cbd6fcbb8cf237f73306e27ed82c3153878aa" }, | ||
| "and_peggy": { "some": 3.141592653589793238426 } | ||
| "and_peggy": { "some": 3.141592653589793238426 }, | ||
| "identity": ["0000000000000000000000000000000000000000000000000000000000000000"] |
There was a problem hiding this comment.
Why is this an array of strings and not just a string?
There was a problem hiding this comment.
Because the internal representation of identity is AlgebraicType::product([("__identity_bytes", AlgebraicType::bytes())])
Keeping the same structure here means avoids having a discrepancy between bsatn, json, satn.
crates/core/src/control_db/tests.rs
Outdated
| let dbs = cdb.get_databases()?; | ||
|
|
||
| assert_eq!(dbs.len(), 1); | ||
| assert_eq!(dbs[0].id, id); |
There was a problem hiding this comment.
I agree with Josh, not sure what is going on here.
mamcx
force-pushed
the
mamcx/identity-hex
branch
from
d7d2507 to
36dfbdf
Compare
|
@cloutiertyler I believe your requested change is in, if you don't mind poking it along |
|
This should close #506 |
Signed-off-by: Mario Montoya <mamcx@elmalabarista.com>
Description of Changes
API and ABI
If the API is breaking, please state below what will break
Expected complexity level and risk
1