core: Replay database prefix #527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kim
commented
Nov 6, 2023
kim
force-pushed
the
kim/truncate-log-in-replay
branch
5 times, most recently
from
5adb3bd to
8416436
Compare
kim
commented
Nov 9, 2023
| ); | ||
| let total_segments = message_log.total_segments(); | ||
|
|
||
| 'replay: for (segment_offset, segment) in message_log.segments().enumerate() { |
There was a problem hiding this comment.
Note that I intend to reduce the rightward drift here and move the replay logic elsewhere.
I left it here for this patch to preserve the side-by-side diff for review.
kim
commented
Nov 9, 2023
kulakowski
approved these changes
Nov 9, 2023
kim
commented
Nov 9, 2023
kim
force-pushed
the
kim/truncate-log-in-replay
branch
from
dc307d5 to
6438675
Compare
If a commit cannot be decoded from the log, stop replaying and truncate the log to the known-good prefix.
When rotating a segment, the max_offset got incremented, leading to a gap of one between the segment's min offset and the offset of the first commit (when viewed as a commit log). This means that offset calculations for truncation or suffix iterators were off by one.
kim
force-pushed
the
kim/truncate-log-in-replay
branch
from
0ecc5cc to
fa0d2e5
Compare
joshua-spacetime
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
When replaying the log, stop if a commit is encountered which cannot be decoded. As this implies a corrupted log, truncate the log to the known-good prefix.
Depends on #526
API and ABI
If the API is breaking, please state below what will break
Expected complexity level and risk
3 -- the risk of truncating the commit log wrongly is data loss.