perf(507): Add disk and memory usage metrics #529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshua-spacetime
force-pushed
the
joshua/perf/507/disk-mem-metrics
branch
2 times, most recently
from
c113b26 to
6706743
Compare
joshua-spacetime
force-pushed
the
joshua/perf/507/disk-mem-metrics
branch
from
6706743 to
305b7d5
Compare
kulakowski
approved these changes
Nov 7, 2023
| @@ -157,6 +157,7 @@ sqllogictest = "0.17" | |||
| strum = { version = "0.25.0", features = ["derive"] } | |||
| syn = { version = "2", features = ["full", "extra-traits"] } | |||
| syntect = { version = "5.0.0", default-features = false, features = ["default-fancy"] } | |||
| sys-info = "0.9.1" | |||
There was a problem hiding this comment.
I'm pretty sure this one is going to be fine because it's a pretty trivial dependency but worth mentioning:
Any time we land something that has an OS dependency (like this does), I'd like the person landing it to be a little heads up in case there's a problem on whichever of linux/macos/windows they don't run on.
kulakowski
pushed a commit
that referenced
this pull request
Nov 7, 2023
kulakowski
pushed a commit
that referenced
this pull request
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #507.
Description of Changes
API and ABI
If the API is breaking, please state below what will break
Expected complexity level and risk
How complicated do you think these changes are? Grade on a scale from 1 to 5,
where 1 is a trivial change, and 5 is a deep-reaching and complex change.
This complexity rating applies not only to the complexity apparent in the diff,
but also to its interactions with existing and future code.
If you answered more than a 2, explain what is complex about the PR,
and what other components it interacts with in potentially concerning ways.