InstanceEnv::delete_by_col_eq: return u32 instead of NonZeroU32
#539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Centril
changed the title
InstanceEnv::delete_by_col_eq: return u32v instead of NonZeroU32`InstanceEnv::delete_by_col_eq: return u32 instead of NonZeroU32
kulakowski
approved these changes
Nov 8, 2023
kulakowski
pushed a commit
that referenced
this pull request
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Fixes an issue that BitCraft were having (spamming INFO messages).
API and ABI
No breakage as the ABI of u32 and the non-zero variant are the same.
Expected complexity level and risk
1 - trivial simple diff with low risk.