Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: Refine panic message when decoding fails during replay #568

Merged
merged 1 commit into from
Nov 16, 2023

Conversation

kim
Copy link
Contributor

@kim kim commented Nov 16, 2023

Description of Changes

It is significant for forensics to differentiate the source of the row data being decoded. Change the error messages to that end.

Expected complexity level and risk

1

It is significant for forensics to differentiate the source of the row
data being decoded. Change the error messages to that end.
@kim kim requested a review from cloutiertyler November 16, 2023 09:17
@kim
Copy link
Contributor Author

kim commented Nov 16, 2023

I am also tempted to make those regular Errs instead of panicking -- the method is already fallible and it would help to be able to determine the commit/transaction offset.

@kim kim merged commit 70332d7 into master Nov 16, 2023
@kim kim deleted the kim/replay-tx-decode-error branch November 16, 2023 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants