Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

system_tables: fix st_indexes_schema inconsistency #569

Merged
merged 1 commit into from
Nov 16, 2023

Conversation

Centril
Copy link
Contributor

@Centril Centril commented Nov 16, 2023

Description of Changes

The order did not correspond to the one in st_fields_enum!(enum StIndexFields { and the TryFrom/From impls.

Possibly breaks ABI of the ST_INDEXES_NAME table.

Expected complexity level and risk

1

@Centril Centril added release-0.8 abi-break A PR that makes an ABI breaking change labels Nov 16, 2023
@Centril Centril requested a review from kim November 16, 2023 12:42
@Centril Centril enabled auto-merge (squash) November 16, 2023 12:46
@Centril Centril force-pushed the centril/fix-inconsistent-st_indexes_schema branch from 2bcaea9 to b4c3f80 Compare November 16, 2023 13:03
@Centril Centril force-pushed the centril/fix-inconsistent-st_indexes_schema branch from b4c3f80 to 1bb848d Compare November 16, 2023 13:23
@Centril Centril merged commit 51e0529 into master Nov 16, 2023
kim added a commit that referenced this pull request Nov 17, 2023
Restarting a database with indexes + sequences is more interesting, in
particular it could have caught #569
kim added a commit that referenced this pull request Nov 17, 2023
Restarting a database with indexes + sequences is more interesting, in
particular it could have caught #569
kim added a commit that referenced this pull request Nov 17, 2023
Restarting a database with indexes + sequences is more interesting, in
particular it could have caught #569
kim added a commit that referenced this pull request Nov 17, 2023
Restarting a database with indexes + sequences is more interesting, in
particular it could have caught #569
kim added a commit that referenced this pull request Nov 17, 2023
Restarting a database with indexes + sequences is more interesting, in
particular it could have caught #569
kim added a commit that referenced this pull request Nov 20, 2023
Restarting a database with indexes + sequences is more interesting, in
particular it could have caught #569
kim added a commit that referenced this pull request Nov 20, 2023
Restarting a database with indexes + sequences is more interesting, in
particular it could have caught #569
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
abi-break A PR that makes an ABI breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants