Move lib::{name,recovery} to client-api-messages #570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@coolreader18 I'd love to do this in general after 0.8 lands. |
bfops
added
the
breaks library compatibility
bfops
added
release-any
coolreader18
force-pushed
the
noa/api-common-crate
branch
2 times, most recently
from
3c5ba95 to
7d27ca1
Compare
coolreader18
force-pushed
the
noa/api-common-crate
branch
from
7d27ca1 to
6961b92
Compare
coolreader18
changed the title
coolreader18
force-pushed
the
noa/api-common-crate
branch
from
6961b92 to
76ec551
Compare
kazimuth
approved these changes
Apr 5, 2024
coolreader18
force-pushed
the
noa/api-common-crate
branch
from
76ec551 to
79c427f
Compare
coolreader18
force-pushed
the
noa/api-common-crate
branch
from
79c427f to
f51bbdd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way,
spacetimedb-libis for stuff that's specifically shared between host and module (that's how I've always interpreted it, at least), and less a catch all for anything that might need to be accessed from 2 different crates. lib is a dependency of bindings, and we should want to keep that as small as is reasonable, so that it builds fast andspacetime init && spacetime buildas an onboarding demo is snappy.Expected complexity level and risk
2, moves some files around so could conflict with other PRs but it's not very
likely nor are there huge changes to the moved files otherwise.