Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup SpacetimeDB name usages #744

Merged
merged 2 commits into from
Jan 23, 2024

Conversation

jdetter
Copy link
Collaborator

@jdetter jdetter commented Jan 23, 2024

Description of Changes

Please describe your change, mention any related tickets, and so on here.

  • Fixed any instances where SpacetimeDB is not spelled correctly

API and ABI breaking changes

If this is an API or ABI breaking change, please apply the
corresponding GitHub label.

  • This may have some small API breakages in tests and things, and we changed the name of a file on disk although I'm not sure that actually impacts the API at all. This probably breaks the API somehow but not in a meaningful way.

Expected complexity level and risk

How complicated do you think these changes are? Grade on a scale from 1 to 5,
where 1 is a trivial change, and 5 is a deep-reaching and complex change.

This complexity rating applies not only to the complexity apparent in the diff,
but also to its interactions with existing and future code.

If you answered more than a 2, explain what is complex about the PR,
and what other components it interacts with in potentially concerning ways.

0

@jdetter jdetter added the abi-break A PR that makes an ABI breaking change label Jan 23, 2024
@jdetter jdetter requested a review from mamcx January 23, 2024 17:26
Copy link
Contributor

@mamcx mamcx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I check the syntax coloring running the repl and looks fine.

@jdetter jdetter added this pull request to the merge queue Jan 23, 2024
Merged via the queue into master with commit d67c1db Jan 23, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
abi-break A PR that makes an ABI breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants