Fix row count for the 'sql' command #745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshua-spacetime
approved these changes
Jan 23, 2024
| @@ -112,7 +112,8 @@ pub(crate) async fn run_sql(builder: RequestBuilder, sql: &str, with_stats: bool | |||
| .map(|stmt_result| { | |||
| let mut table = stmt_result_to_table(stmt_result)?; | |||
| if with_stats { | |||
| let row_count = print_row_count(table.count_rows()); | |||
| // The `tabled::count_rows` add the header as a row, so subtract it. | |||
| let row_count = print_row_count(table.count_rows().wrapping_sub(1)); | |||
There was a problem hiding this comment.
Are you able to update count_rows instead?
There was a problem hiding this comment.
No, that is from a external crate tabled
There was a problem hiding this comment.
I agree that this is super jank but if this is how the external crate determines this value then I think this is the best we can do 🤷♂️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
The
tabledlibrary add the header as part of the number of rows...API and ABI breaking changes
If this is an API or ABI breaking change, please apply the
corresponding GitHub label.
Expected complexity level and risk
1