SATS: add support needed for BFLATN => BSATN directly #750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gefjon
approved these changes
Jan 24, 2024
crates/sats/src/bsatn/ser.rs
Outdated
Comment on lines
148
to
149
| unsafe fn serialize_bsatn(self, _: &crate::AlgebraicType, bsatn: &[u8]) -> Result<Self::Ok, Self::Error> { | ||
| self.writer.put_slice(bsatn); |
There was a problem hiding this comment.
Is there a meaningful debug_assert! you could add here that the bsatn is compatible with the (currently ignored) AlgebraicType?
There was a problem hiding this comment.
Sure, you could do basically what the safety requirement of calling this method is.
It is a bit expensive, possibly even for debug mode, but I'll add it for now.
There was a problem hiding this comment.
In the other cases, we'd need to make the iterator clonable but I can add that too.
Also some associated refactoring
Centril
force-pushed
the
centril/sats-bflatn-bsatn
branch
from
402146b to
cf2827c
Compare
Co-authored-by: Phoebe Goldman <phoebe@clockworklabs.io> Signed-off-by: Mazdak Farrokhzad <twingoow@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also some associated refactoring
Description of Changes
Extends
spacetimedb_sats::ser::Serializerto support:Adds
spacetimedb_sats::bsatn::to_lenwhich computes the length of a bsatn encoding without storing the encoding.API and ABI breaking changes
None
Expected complexity level and risk
2, Some unsafe code, and this extends the
Serializertrait.