Use rayon for broadcast_commit_event #779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coolreader18
commented
Jan 29, 2024
coolreader18
force-pushed
the
noa/rayon_broadcast_commit
branch
from
6892ed0 to
f851050
Compare
|
@joshua-spacetime No overhead, actually! It should make things more efficient, since instead of spawning N threads for however many subscribers there are, it puts it on a threadpool, so it's still parallelized but there's less contention. (John and I just figured out that that attribute fixes the deadlock we've been having) |
jdetter
approved these changes
Jan 30, 2024
joshua-spacetime
approved these changes
Jan 30, 2024
coolreader18
force-pushed
the
noa/rayon_broadcast_commit
branch
from
b0af292 to
3606f2b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Switch to rayon for broadcast_commit_event - this makes the concurrency more straightforward to follow, and I think would make it easier to update in the future.
Expected complexity level and risk
1