BTreeIndex: Specialize on primitive key types for great performance #793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rewrite of Tyler's #771, because I thought this would be easier than rebasing. This commit hoists branching on key types outside of comparisons and searches in `BTreeIndex`, so that in many cases we can use e.g. `u64::cmp` instead of the much slower `AlgebraicValue::cmp`. This design is kind of ugly, and will likely change in the future, but for now it's good enough, and is a meaningful performance improvement.
|
benchmarks please |
Benchmark resultsBenchmark ReportLegend:
All throughputs are single-threaded. Empty transaction
Single-row insertions
Multi-row insertions
Full table iterate
Find unique key
Filter
Serialize
Module: invoke with large arguments
Module: print bulk
Remaining benchmarks
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Rewrite of Tyler's #771, because I thought this would be easier than rebasing.
This commit hoists branching on key types outside of comparisons and searches in
BTreeIndex, so that in many cases we can use e.g.u64::cmpinstead of the much slowerAlgebraicValue::cmp.This design is kind of ugly, and will likely change in the future, but for now it's good enough, and is a meaningful performance improvement.
API and ABI breaking changes
No external interfaces change.
Expected complexity level and risk
2 - ugly code with lots of repetitive matching may open us up to copy/paste errors.