Fix Connection Error: Success #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdetter
force-pushed
the
jdetter/fix-connection-error-success
branch
from
4c9b423 to
240b220
Compare
|
Put it to rest, once and for all! |
lcodes
force-pushed
the
jdetter/fix-connection-error-success
branch
from
a5311e9 to
3760dbc
Compare
lcodes
reviewed
Oct 30, 2024
lcodes
reviewed
Oct 30, 2024
lcodes
reviewed
Oct 30, 2024
lcodes
reviewed
Oct 30, 2024
lcodes
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
This PR edits the handling of errors related to websocket connections and disconnections. In particular, clients and users would often run into the dreaded
Connection Error: Successmessage which was confusing and frustrating. This PR better addresses the error by providing more guidance and debug info for the user. It is unfortunately still suboptimal because theHttpStatusCodeis not available in the .NET core version that Unity supports. We try to be as helpful as possible in this scenario.API
OnDisconnectandOnConnectErrorcallbacks to implement the API specification: https://github.com/clockworklabs/SpacetimeDBPrivate/pull/866/files#diff-be533cc04817c33605a68d717c6ec320c4449904266ee8e1096971e9e17e8d31R424Requires SpacetimeDB PRs
No changes to SpacetimeDB required.
Testing
I, Tyler, have tested this and confirmed it to be working with CircleGame. Here is a sample of the output in the case of
Connection Error: Success: