Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Identity and Address to use bigints rather than byte arrays #119

Merged
merged 7 commits into from
Nov 4, 2024

Conversation

kazimuth
Copy link
Contributor

Description of Changes

This makes us compatible with the main repo again.

API

  • This is an API breaking change to the SDK

The data field of Address and Identity

Requires SpacetimeDB PRs

clockworklabs/SpacetimeDB#1616 which merged a while ago, whoops!

@kazimuth kazimuth requested a review from PuruVJ October 30, 2024 17:02
Copy link

changeset-bot bot commented Oct 30, 2024

🦋 Changeset detected

Latest commit: 99520e6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@clockworklabs/spacetimedb-sdk Minor
@clockworklabs/test-app Patch
client-vite Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

pkg-pr-new bot commented Oct 30, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/@clockworklabs/spacetimedb-sdk@119

commit: 99520e6

packages/sdk/src/address.ts Outdated Show resolved Hide resolved
packages/sdk/src/algebraic_type.ts Outdated Show resolved Hide resolved
packages/sdk/src/algebraic_type.ts Show resolved Hide resolved
packages/sdk/src/algebraic_type.ts Outdated Show resolved Hide resolved
packages/sdk/src/identity.ts Outdated Show resolved Hide resolved
@cloutiertyler
Copy link
Contributor

@PuruVJ To test this works after @Centril addresses comments

@PuruVJ PuruVJ merged commit 6547882 into main Nov 4, 2024
6 checks passed
@PuruVJ PuruVJ deleted the jgilles/identity_unbytes branch November 4, 2024 18:41
@github-actions github-actions bot mentioned this pull request Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants